diff options
| author | Alvaro Herrera | 2013-01-02 15:01:14 +0000 |
|---|---|---|
| committer | Alvaro Herrera | 2013-01-02 15:01:14 +0000 |
| commit | cdbc0ca48ca96e5c787b1605ed2d6cf7407a5acf (patch) | |
| tree | f8e0e768c9d68dc79de634e35d10beb8f569039d /src/include | |
| parent | d194d7a52630d855f43edbf0129e131099af6c14 (diff) | |
Fix background workers for EXEC_BACKEND
Commit da07a1e8 was broken for EXEC_BACKEND because I failed to realize
that the MaxBackends recomputation needed to be duplicated by
subprocesses in SubPostmasterMain. However, instead of having the value
be recomputed at all, it's better to assign the correct value at
postmaster initialization time, and have it be propagated to exec'ed
backends via BackendParameters.
MaxBackends stays as zero until after modules in
shared_preload_libraries have had a chance to register bgworkers, since
the value is going to be untrustworthy till that's finished.
Heikki Linnakangas and Álvaro Herrera
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/postmaster/postmaster.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/include/postmaster/postmaster.h b/src/include/postmaster/postmaster.h index eaca868b008..8b2d5b913e3 100644 --- a/src/include/postmaster/postmaster.h +++ b/src/include/postmaster/postmaster.h @@ -61,4 +61,13 @@ extern Size ShmemBackendArraySize(void); extern void ShmemBackendArrayAllocation(void); #endif +/* + * Note: MAX_BACKENDS is limited to 2^23-1 because inval.c stores the + * backend ID as a 3-byte signed integer. Even if that limitation were + * removed, we still could not exceed INT_MAX/4 because some places compute + * 4*MaxBackends without any overflow check. This is rechecked in the relevant + * GUC check hooks and in RegisterBackgroundWorker(). + */ +#define MAX_BACKENDS 0x7fffff + #endif /* _POSTMASTER_H */ |