diff options
| author | Tom Lane | 2007-07-08 22:23:16 +0000 |
|---|---|---|
| committer | Tom Lane | 2007-07-08 22:23:16 +0000 |
| commit | b09cb0cf12e797339f13ed05d02e2d809248a61f (patch) | |
| tree | 92d875d88e909bc1d6e5bb0983e17c5ad9b97600 /src/include | |
| parent | 8331c11f3f6d9f4b9a194b928f7d8380e8a16e5b (diff) | |
Remove the pgstat_drop_relation() call from smgr_internal_unlink(), because
we don't know at that point which relation OID to tell pgstat to forget.
The code was passing the relfilenode, which is incorrect, and could possibly
cause some other relation's stats to be zeroed out. While we could try to
clean this up, it seems much simpler and more reliable to let the next
invocation of pgstat_vacuum_tabstat() fix things; which indeed is how it
worked before I introduced the buggy code into 8.1.3 and later :-(.
Problem noticed by Itagaki Takahiro, fix is per subsequent discussion.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/pgstat.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/include/pgstat.h b/src/include/pgstat.h index acdd039b3e4..960daac5000 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -5,7 +5,7 @@ * * Copyright (c) 2001-2007, PostgreSQL Global Development Group * - * $PostgreSQL: pgsql/src/include/pgstat.h,v 1.63 2007/06/28 00:02:40 tgl Exp $ + * $PostgreSQL: pgsql/src/include/pgstat.h,v 1.64 2007/07/08 22:23:16 tgl Exp $ * ---------- */ #ifndef PGSTAT_H @@ -486,7 +486,6 @@ extern void pgstat_ping(void); extern void pgstat_report_tabstat(bool force); extern void pgstat_vacuum_tabstat(void); extern void pgstat_drop_database(Oid databaseid); -extern void pgstat_drop_relation(Oid relid); extern void pgstat_clear_snapshot(void); extern void pgstat_reset_counters(void); |