diff options
| author | Tom Lane | 2017-02-25 21:12:24 +0000 |
|---|---|---|
| committer | Tom Lane | 2017-02-25 21:12:55 +0000 |
| commit | 9e3755ecb2d058f7d123dd35a2e1784006190962 (patch) | |
| tree | f938cae7833ef756947d4ac074a83d31f5f6113d /src/include | |
| parent | 5639ceddcb7f3efa8751b2ba6e50cc1d27cc2a45 (diff) | |
Remove useless duplicate inclusions of system header files.
c.h #includes a number of core libc header files, such as <stdio.h>.
There's no point in re-including these after having read postgres.h,
postgres_fe.h, or c.h; so remove code that did so.
While at it, also fix some places that were ignoring our standard pattern
of "include postgres[_fe].h, then system header files, then other Postgres
header files". While there's not any great magic in doing it that way
rather than system headers last, it's silly to have just a few files
deviating from the general pattern. (But I didn't attempt to enforce this
globally, only in files I was touching anyway.)
I'd be the first to say that this is mostly compulsive neatnik-ism,
but over time it might save enough compile cycles to be useful.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/libpq/libpq.h | 1 | ||||
| -rw-r--r-- | src/include/port/atomics/generic-msvc.h | 1 | ||||
| -rw-r--r-- | src/include/utils/pg_locale.h | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/src/include/libpq/libpq.h b/src/include/libpq/libpq.h index 538066e1067..d4885a5e282 100644 --- a/src/include/libpq/libpq.h +++ b/src/include/libpq/libpq.h @@ -14,7 +14,6 @@ #ifndef LIBPQ_H #define LIBPQ_H -#include <sys/types.h> #include <netinet/in.h> #include "lib/stringinfo.h" diff --git a/src/include/port/atomics/generic-msvc.h b/src/include/port/atomics/generic-msvc.h index c7caf04d57e..d5ee6e1bcbe 100644 --- a/src/include/port/atomics/generic-msvc.h +++ b/src/include/port/atomics/generic-msvc.h @@ -17,7 +17,6 @@ *------------------------------------------------------------------------- */ #include <intrin.h> -#include <windows.h> /* intentionally no include guards, should only be included by atomics.h */ #ifndef INSIDE_ATOMICS_H diff --git a/src/include/utils/pg_locale.h b/src/include/utils/pg_locale.h index be91f9b88c7..cb509e2b6b0 100644 --- a/src/include/utils/pg_locale.h +++ b/src/include/utils/pg_locale.h @@ -12,7 +12,6 @@ #ifndef _PG_LOCALE_ #define _PG_LOCALE_ -#include <locale.h> #if defined(LOCALE_T_IN_XLOCALE) || defined(WCSTOMBS_L_IN_XLOCALE) #include <xlocale.h> #endif |