diff options
| author | Tom Lane | 2012-11-26 20:55:43 +0000 |
|---|---|---|
| committer | Tom Lane | 2012-11-26 20:55:43 +0000 |
| commit | 532994299e2ff208a58376134fab75f5ae471e41 (patch) | |
| tree | 640a22d6172d9dbdccf88ecc1195c6a23a3b0a8c /src/include | |
| parent | d3237e04ca380d6c08f6133fde97a9d956e3161a (diff) | |
Revert patch for taking fewer snapshots.
This reverts commit d573e239f03506920938bf0be56c868d9c3416da, "Take fewer
snapshots". While that seemed like a good idea at the time, it caused
execution to use a snapshot that had been acquired before locking any of
the tables mentioned in the query. This created user-visible anomalies
that were not present in any prior release of Postgres, as reported by
Tomas Vondra. While this whole area could do with a redesign (since there
are related cases that have anomalies anyway), it doesn't seem likely that
any future patch would be reasonably back-patchable; and we don't want 9.2
to exhibit a behavior that's subtly unlike either past or future releases.
Hence, revert to prior code while we rethink the problem.
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/tcop/pquery.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/tcop/pquery.h b/src/include/tcop/pquery.h index 22aad2e96cc..c77bb8be948 100644 --- a/src/include/tcop/pquery.h +++ b/src/include/tcop/pquery.h @@ -28,7 +28,7 @@ extern List *FetchPortalTargetList(Portal portal); extern List *FetchStatementTargetList(Node *stmt); extern void PortalStart(Portal portal, ParamListInfo params, - int eflags, bool use_active_snapshot); + int eflags, Snapshot snapshot); extern void PortalSetResultFormat(Portal portal, int nFormats, int16 *formats); |