diff options
| author | Tom Lane | 2022-02-18 03:45:34 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-02-18 03:45:34 +0000 |
| commit | 46b738ffc2bf27c1c0bf0492f8c646c4496819dc (patch) | |
| tree | bfad592f5d0452c7554f4931936c904ca667c3de /src/include | |
| parent | 0dc0284ade4ade315982d1300cb87006b42e72c3 (diff) | |
Suppress warning about stack_base_ptr with late-model GCC.
GCC 12 complains that set_stack_base is storing the address of
a local variable in a long-lived pointer. This is an entirely
reasonable warning (indeed, it just helped us find a bug);
but that behavior is intentional here. We can work around it
by using __builtin_frame_address(0) instead of a specific local
variable; that produces an address a dozen or so bytes different,
in my testing, but we don't care about such a small difference.
Maybe someday a compiler lacking that function will start to issue
a similar warning, but we'll worry about that when it happens.
Patch by me, per a suggestion from Andres Freund. Back-patch to
v12, which is as far back as the patch will go without some pain.
(Recently-established project policy would permit a back-patch as
far as 9.2, but I'm disinclined to expend the work until GCC 12
is much more widespread.)
Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/pg_config.h.in | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index 66c53c52bbc..2711c2ce9bd 100644 --- a/src/include/pg_config.h.in +++ b/src/include/pg_config.h.in @@ -707,6 +707,9 @@ /* Define to 1 if your compiler understands __builtin_ctz. */ #undef HAVE__BUILTIN_CTZ +/* Define to 1 if your compiler understands __builtin_frame_address. */ +#undef HAVE__BUILTIN_FRAME_ADDRESS + /* Define to 1 if your compiler understands __builtin_$op_overflow. */ #undef HAVE__BUILTIN_OP_OVERFLOW |