diff options
| author | Andres Freund | 2019-02-06 09:09:32 +0000 |
|---|---|---|
| committer | Andres Freund | 2019-02-06 09:09:32 +0000 |
| commit | 171e0418b03dc103d5d9bdc0bfaadbb193dd7fd6 (patch) | |
| tree | ff26943d0315fe748706952a9678eaeaf2ad86a5 /src/include | |
| parent | d07fb6810e51a676c4c631f673b8da09f63205b3 (diff) | |
Fix heap_getattr() handling of fast defaults.
Previously heap_getattr() returned NULL for attributes with a fast
default value (c.f. 16828d5c0273), as it had no handling whatsoever
for that case.
A previous fix, 7636e5c60f, attempted to fix issues caused by this
oversight, but just expanding OLD tuples for triggers doesn't actually
solve the underlying issue.
One known consequence of this bug is that the check for HOT updates
can return the wrong result, when a previously fast-default'ed column
is set to NULL. Which in turn means that an index over a column with
fast default'ed columns might be corrupt if the underlying column(s)
allow NULLs.
Fix by handling fast default columns in heap_getattr(), remove now
superfluous expansion in GetTupleForTrigger().
Author: Andres Freund
Discussion: https://postgr.es/m/20190201162404.onngi77f26baem4g@alap3.anarazel.de
Backpatch: 11, where fast defaults were introduced
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/access/htup_details.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/include/access/htup_details.h b/src/include/access/htup_details.h index 873a3015fc4..6d51f9062ba 100644 --- a/src/include/access/htup_details.h +++ b/src/include/access/htup_details.h @@ -764,10 +764,7 @@ extern Datum fastgetattr(HeapTuple tup, int attnum, TupleDesc tupleDesc, ((attnum) > 0) ? \ ( \ ((attnum) > (int) HeapTupleHeaderGetNatts((tup)->t_data)) ? \ - ( \ - (*(isnull) = true), \ - (Datum)NULL \ - ) \ + getmissingattr((tupleDesc), (attnum), (isnull)) \ : \ fastgetattr((tup), (attnum), (tupleDesc), (isnull)) \ ) \ @@ -788,6 +785,8 @@ extern Datum nocachegetattr(HeapTuple tup, int attnum, TupleDesc att); extern Datum heap_getsysattr(HeapTuple tup, int attnum, TupleDesc tupleDesc, bool *isnull); +extern Datum getmissingattr(TupleDesc tupleDesc, + int attnum, bool *isnull); extern HeapTuple heap_copytuple(HeapTuple tuple); extern void heap_copytuple_with_tuple(HeapTuple src, HeapTuple dest); extern Datum heap_copy_tuple_as_datum(HeapTuple tuple, TupleDesc tupleDesc); |