diff options
| author | Tom Lane | 2025-01-30 18:21:42 +0000 |
|---|---|---|
| committer | Tom Lane | 2025-01-30 18:21:42 +0000 |
| commit | 115a365519bfd53a65bf17d253b26902eff0c337 (patch) | |
| tree | 809dcf8dcfd0ec0b82fce588557af80073005b02 /src/include | |
| parent | 6252b1eaf82bb8db361341d1c8651e43b29be816 (diff) | |
Simplify executor's handling of CaseTestExpr & CoerceToDomainValue.
Instead of deciding at runtime whether to read from casetest.value
or caseValue_datum, split EEOP_CASE_TESTVAL into two opcodes and
make the decision during expression compilation. Similarly for
EEOP_DOMAIN_TESTVAL. This actually results in net less code,
mainly because llvmjit_expr.c's code for handling these opcodes
gets shorter. The performance gain is doubtless negligible, but
this seems worth changing anyway on grounds of simplicity and
understandability.
Author: Andreas Karlsson <andreas@proxel.se>
Co-authored-by: Xing Guo <higuoxing@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACpMh+AiBYAWn+D1aU7Rsy-V1tox06Cbc0H3qA7rwL5zdJ=anQ@mail.gmail.com
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/executor/execExpr.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/include/executor/execExpr.h b/src/include/executor/execExpr.h index 5371e344ecd..51bd35dcb07 100644 --- a/src/include/executor/execExpr.h +++ b/src/include/executor/execExpr.h @@ -173,6 +173,7 @@ typedef enum ExprEvalOp /* return CaseTestExpr value */ EEOP_CASE_TESTVAL, + EEOP_CASE_TESTVAL_EXT, /* apply MakeExpandedObjectReadOnly() to target value */ EEOP_MAKE_READONLY, @@ -237,6 +238,7 @@ typedef enum ExprEvalOp /* evaluate value for CoerceToDomainValue */ EEOP_DOMAIN_TESTVAL, + EEOP_DOMAIN_TESTVAL_EXT, /* evaluate a domain's NOT NULL constraint */ EEOP_DOMAIN_NOTNULL, |