diff options
| author | Amit Kapila | 2023-12-07 03:12:48 +0000 |
|---|---|---|
| committer | Amit Kapila | 2023-12-07 03:12:48 +0000 |
| commit | 0bf62460bb9e86101d24e31e915c2e8922675296 (patch) | |
| tree | a106f9e1152d03df618ca5000671014eebd88932 /src/include | |
| parent | c426f7c2b36a5efd9bcef2a2dfcc559f7879cd84 (diff) | |
Fix issues in binary_upgrade_logical_slot_has_caught_up().
The commit 29d0a77fa6 labelled binary_upgrade_logical_slot_has_caught_up()
as a non-strict function to allow providing a better error message to callers
in case the passed slot_name is NULL. On further discussion, it seems that
it is not helpful to have a different error message for NULL input in this
function, so this patch marks the function as strict.
This patch also removes the explicit permission check to use replication
slots as this function is invoked only by superusers and instead adds an
Assert.
Reported-by: Masahiko Sawada
Author: Hayato Kuroda
Reviewed-by: Vignesh C
Discussion: https://postgr.es/m/CAD21AoDSyiBKkMXBxN_gUayZZUCOgyHnG8Ge8rcPXNP3Tf6B4g@mail.gmail.com
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/catalog/catversion.h | 2 | ||||
| -rw-r--r-- | src/include/catalog/pg_proc.dat | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/src/include/catalog/catversion.h b/src/include/catalog/catversion.h index c4c59bfe6f9..a06a8f0b23b 100644 --- a/src/include/catalog/catversion.h +++ b/src/include/catalog/catversion.h @@ -57,6 +57,6 @@ */ /* yyyymmddN */ -#define CATALOG_VERSION_NO 202311271 +#define CATALOG_VERSION_NO 202312071 #endif diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index fb58dee3bcd..77e8b137649 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -11392,9 +11392,8 @@ proparallel => 'u', prorettype => 'void', proargtypes => 'oid', prosrc => 'binary_upgrade_set_next_pg_tablespace_oid' }, { oid => '8046', descr => 'for use by pg_upgrade', - proname => 'binary_upgrade_logical_slot_has_caught_up', proisstrict => 'f', - provolatile => 'v', proparallel => 'u', prorettype => 'bool', - proargtypes => 'name', + proname => 'binary_upgrade_logical_slot_has_caught_up', provolatile => 'v', + proparallel => 'u', prorettype => 'bool', proargtypes => 'name', prosrc => 'binary_upgrade_logical_slot_has_caught_up' }, # conversion functions |