diff options
| author | Noah Misch | 2021-10-24 01:36:38 +0000 |
|---|---|---|
| committer | Noah Misch | 2021-10-24 01:36:43 +0000 |
| commit | 5141e471b36add19fe9d6b461f9ea11c0ca6b373 (patch) | |
| tree | 662c14ffdd2616757586e4ceebc045012f53b7e9 /src/include/utils | |
| parent | e6c5f1b452655a20b687b3e39d8eb816d8f8cbf7 (diff) | |
Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.
CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
no later than each backend's next transaction start. That failed to
hold when a backend absorbed a relevant invalidation in the middle of
running RelationBuildDesc() on the CIC index. Queries that use the
resulting index can silently fail to find rows. Fix this for future
index builds by making RelationBuildDesc() loop until it finishes
without accepting a relevant invalidation. It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
Back-patch to 9.6 (all supported versions).
Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
Freund.
Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
Diffstat (limited to 'src/include/utils')
| -rw-r--r-- | src/include/utils/inval.h | 1 | ||||
| -rw-r--r-- | src/include/utils/relcache.h | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/include/utils/inval.h b/src/include/utils/inval.h index 7a66d466f70..31a54e5aa3c 100644 --- a/src/include/utils/inval.h +++ b/src/include/utils/inval.h @@ -63,4 +63,5 @@ extern void CacheRegisterRelcacheCallback(RelcacheCallbackFunction func, extern void CallSyscacheCallbacks(int cacheid, uint32 hashvalue); extern void InvalidateSystemCaches(void); +extern void InvalidateSystemCachesExtended(bool debug_discard); #endif /* INVAL_H */ diff --git a/src/include/utils/relcache.h b/src/include/utils/relcache.h index 54394303a85..8c4e2642b84 100644 --- a/src/include/utils/relcache.h +++ b/src/include/utils/relcache.h @@ -120,7 +120,7 @@ extern void RelationForgetRelation(Oid rid); extern void RelationCacheInvalidateEntry(Oid relationId); -extern void RelationCacheInvalidate(void); +extern void RelationCacheInvalidate(bool debug_discard); extern void RelationCloseSmgrByOid(Oid relationId); |