diff options
| author | Alvaro Herrera | 2021-05-06 16:47:30 +0000 |
|---|---|---|
| committer | Alvaro Herrera | 2021-05-06 16:47:30 +0000 |
| commit | 3fe773b149755977d2ffde2afd89557b39d0afd9 (patch) | |
| tree | 1f3685487291a4d1d6cf78766e2c5553b4fb4721 /src/include/utils | |
| parent | c38cadc0907a8d071b043b2b32b83efa09db38ea (diff) | |
Track detached partitions more accurately in partdescs
In d6b8d29419df I (Álvaro) was sloppy about recording whether a
partition descripor does or does not include detached partitions, when
the snapshot checking does not see the pg_inherits row marked detached.
In that case no partition was omitted, yet in the relcache entry we were
saving the partdesc as omitting partitions. Flip that (so we save it as
a partdesc not omitting partitions, which indeed it doesn't), which
hopefully makes the code easier to reason about.
Author: Amit Langote <amitlangote09@gmail.com>
Discussion: https://postgr.es/m/CA+HiwqE7GxGU4VdzwZzfiz+Ont5SsopoFkgtrZGEdPqWRL+biA@mail.gmail.com
Diffstat (limited to 'src/include/utils')
| -rw-r--r-- | src/include/utils/rel.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/include/utils/rel.h b/src/include/utils/rel.h index 07ae2c70a96..5bd44be9a79 100644 --- a/src/include/utils/rel.h +++ b/src/include/utils/rel.h @@ -138,9 +138,7 @@ typedef struct RelationData * rd_partdesc_nodetached. This informs a future user of that partdesc: * if this value is not in progress for the active snapshot, then the * partdesc can be used, otherwise they have to build a new one. (This - * matches what find_inheritance_children_extended would do). In the rare - * case where the pg_inherits tuple has been frozen, this will be - * InvalidXid; behave as if the partdesc is unusable in that case. + * matches what find_inheritance_children_extended would do). */ TransactionId rd_partdesc_nodetached_xmin; |