diff options
| author | Alvaro Herrera | 2020-05-08 19:30:34 +0000 |
|---|---|---|
| committer | Alvaro Herrera | 2020-05-08 19:40:11 +0000 |
| commit | b060dbe0001a1d6bf26cd294710f3cb203868d46 (patch) | |
| tree | 6e9e980aa63ec1ec3655b93c92b9b5caa6689d38 /src/include/replication | |
| parent | 871696ba20e0251e86041576373809d1c7ca161d (diff) | |
Rework XLogReader callback system
Code review for 0dc8ead46363, prompted by a bug closed by 91c40548d5f7.
XLogReader's system for opening and closing segments had gotten too
complicated, with callbacks being passed at both the XLogReaderAllocate
level (read_page) as well as at the WALRead level (segment_open). This
was confusing and hard to follow, so restructure things so that these
callbacks are passed together at XLogReaderAllocate time, and add
another callback to the set (segment_close) to make it a coherent whole.
Also, ensure XLogReaderState is an argument to all the callbacks, so
that they can grab at the ->private data if necessary.
Document the whole arrangement more clearly.
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20200422175754.GA19858@alvherre.pgsql
Diffstat (limited to 'src/include/replication')
| -rw-r--r-- | src/include/replication/logical.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/include/replication/logical.h b/src/include/replication/logical.h index 3b7ca7f1da4..c2f2475e5d3 100644 --- a/src/include/replication/logical.h +++ b/src/include/replication/logical.h @@ -95,14 +95,14 @@ extern LogicalDecodingContext *CreateInitDecodingContext(char *plugin, List *output_plugin_options, bool need_full_snapshot, XLogRecPtr restart_lsn, - XLogPageReadCB read_page, + XLogReaderRoutine *xl_routine, LogicalOutputPluginWriterPrepareWrite prepare_write, LogicalOutputPluginWriterWrite do_write, LogicalOutputPluginWriterUpdateProgress update_progress); extern LogicalDecodingContext *CreateDecodingContext(XLogRecPtr start_lsn, List *output_plugin_options, bool fast_forward, - XLogPageReadCB read_page, + XLogReaderRoutine *xl_routine, LogicalOutputPluginWriterPrepareWrite prepare_write, LogicalOutputPluginWriterWrite do_write, LogicalOutputPluginWriterUpdateProgress update_progress); |