diff options
| author | Tom Lane | 2022-12-27 17:26:01 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-12-27 17:26:01 +0000 |
| commit | 858e776c84f48841e7e16fba7b690b76e54f3675 (patch) | |
| tree | d66a1512ca446af90173d5ff8fd57863f98be6f7 /src/include/parser | |
| parent | 78212f21011449f0374831323655baa7c00f3680 (diff) | |
Convert the reg* input functions to report (most) errors softly.
This is not really complete, but it catches most cases of practical
interest. The main omissions are:
* regtype, regprocedure, and regoperator parse type names by
calling the main grammar, so any grammar-detected syntax error
will still be a hard error. Also, if one includes a type
modifier in such a type specification, errors detected by the
typmodin function will be hard errors.
* Lookup errors are handled just by passing missing_ok = true
to the relevant catalog lookup function. Because we've used
quite a restrictive definition of "missing_ok", this means that
edge cases such as "the named schema exists, but you lack
USAGE permission on it" are still hard errors.
It would make sense to me to replace most/all missing_ok
parameters with an escontext parameter and then allow these
additional lookup failure cases to be trapped too. But that's
a job for some other day.
Discussion: https://postgr.es/m/3342239.1671988406@sss.pgh.pa.us
Diffstat (limited to 'src/include/parser')
| -rw-r--r-- | src/include/parser/parse_type.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/include/parser/parse_type.h b/src/include/parser/parse_type.h index 4e5624d721c..c6c92a00097 100644 --- a/src/include/parser/parse_type.h +++ b/src/include/parser/parse_type.h @@ -51,8 +51,9 @@ extern Datum stringTypeDatum(Type tp, char *string, int32 atttypmod); extern Oid typeidTypeRelid(Oid type_id); extern Oid typeOrDomainTypeRelid(Oid type_id); -extern TypeName *typeStringToTypeName(const char *str); -extern void parseTypeString(const char *str, Oid *typeid_p, int32 *typmod_p, bool missing_ok); +extern TypeName *typeStringToTypeName(const char *str, Node *escontext); +extern bool parseTypeString(const char *str, Oid *typeid_p, int32 *typmod_p, + Node *escontext); /* true if typeid is composite, or domain over composite, but not RECORD */ #define ISCOMPLEX(typeid) (typeOrDomainTypeRelid(typeid) != InvalidOid) |