diff options
| author | Tom Lane | 2017-06-04 17:34:05 +0000 |
|---|---|---|
| committer | Tom Lane | 2017-06-04 17:34:05 +0000 |
| commit | 9db7d47f909482ac2b76c28f5e9a2ef48fb19b9d (patch) | |
| tree | e940c41990ca01f73d28f234d283190c6a5fa364 /src/include/optimizer | |
| parent | 0d1885266630eee1de5c43af463fe2b921451932 (diff) | |
#ifdef out assorted unused GEQO code.
I'd always assumed that backend/optimizer/geqo/'s remarkably poor
showing on code coverage metrics was because we weren't exercising
it much in the regression tests. But it turns out that a good chunk
of the problem is that there's a bunch of code that is physically
unreachable (because the calls to it are #ifdef'd out in geqo_main.c)
but is being built anyway. Making the called code have #if guards
similar to the calling code saves a couple of kilobytes of executable
size and should make the coverage numbers more reflective of reality.
It's arguable that we should just delete all the unused recombination
mechanisms altogether, but I didn't feel a need to go that far today.
Diffstat (limited to 'src/include/optimizer')
| -rw-r--r-- | src/include/optimizer/geqo.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/optimizer/geqo.h b/src/include/optimizer/geqo.h index 6b09c4e1951..be65c054e10 100644 --- a/src/include/optimizer/geqo.h +++ b/src/include/optimizer/geqo.h @@ -31,7 +31,7 @@ #define GEQO_DEBUG */ -/* recombination mechanism */ +/* choose one recombination mechanism here */ /* #define ERX #define PMX |