diff options
| author | Robert Haas | 2014-02-19 15:06:59 +0000 |
|---|---|---|
| committer | Robert Haas | 2014-02-19 15:06:59 +0000 |
| commit | 694e3d139a9d090c58494428bebfadad216419da (patch) | |
| tree | 80d2d1acb1e2cb584597a6fc4560ebbf97250574 /src/include/fmgr.h | |
| parent | 844a28a9dd1a48045ad1db9246da5e2783c9bd40 (diff) | |
Further code review for pg_lsn data type.
Change input function error messages to be more consistent with what is
done elsewhere. Remove a bunch of redundant type casts, so that the
compiler will warn us if we screw up. Don't pass LSNs by value on
platforms where a Datum is only 32 bytes, per buildfarm. Move macros
for packing and unpacking LSNs to pg_lsn.h so that we can include
access/xlogdefs.h, to avoid an unsatisfied dependency on XLogRecPtr.
Diffstat (limited to 'src/include/fmgr.h')
| -rw-r--r-- | src/include/fmgr.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/include/fmgr.h b/src/include/fmgr.h index dd4c672bafc..aed81cdc26b 100644 --- a/src/include/fmgr.h +++ b/src/include/fmgr.h @@ -230,7 +230,6 @@ extern struct varlena *pg_detoast_datum_packed(struct varlena * datum); #define PG_GETARG_CHAR(n) DatumGetChar(PG_GETARG_DATUM(n)) #define PG_GETARG_BOOL(n) DatumGetBool(PG_GETARG_DATUM(n)) #define PG_GETARG_OID(n) DatumGetObjectId(PG_GETARG_DATUM(n)) -#define PG_GETARG_LSN(n) DatumGetLSN(PG_GETARG_DATUM(n)) #define PG_GETARG_POINTER(n) DatumGetPointer(PG_GETARG_DATUM(n)) #define PG_GETARG_CSTRING(n) DatumGetCString(PG_GETARG_DATUM(n)) #define PG_GETARG_NAME(n) DatumGetName(PG_GETARG_DATUM(n)) @@ -303,7 +302,6 @@ extern struct varlena *pg_detoast_datum_packed(struct varlena * datum); #define PG_RETURN_CHAR(x) return CharGetDatum(x) #define PG_RETURN_BOOL(x) return BoolGetDatum(x) #define PG_RETURN_OID(x) return ObjectIdGetDatum(x) -#define PG_RETURN_LSN(x) return LSNGetDatum(x) #define PG_RETURN_POINTER(x) return PointerGetDatum(x) #define PG_RETURN_CSTRING(x) return CStringGetDatum(x) #define PG_RETURN_NAME(x) return NameGetDatum(x) |