diff options
| author | Michael Paquier | 2019-08-13 04:53:41 +0000 |
|---|---|---|
| committer | Michael Paquier | 2019-08-13 04:53:41 +0000 |
| commit | 66bde49d96a9ddacc49dcbdf1b47b5bd6e31ead5 (patch) | |
| tree | 638a0aacba92dab819aa9add708297202211c4aa /src/include/access | |
| parent | 2d7d67cc74d0f59e76464bd5009bc74f1591018e (diff) | |
Fix inconsistencies and typos in the tree, take 10
This addresses some issues with unnecessary code comments, fixes various
typos in docs and comments, and removes some orphaned structures and
definitions.
Author: Alexander Lakhin
Discussion: https://postgr.es/m/9aabc775-5494-b372-8bcb-4dfc0bd37c68@gmail.com
Diffstat (limited to 'src/include/access')
| -rw-r--r-- | src/include/access/brin_revmap.h | 2 | ||||
| -rw-r--r-- | src/include/access/hash_xlog.h | 13 | ||||
| -rw-r--r-- | src/include/access/reloptions.h | 2 | ||||
| -rw-r--r-- | src/include/access/xlogreader.h | 2 |
4 files changed, 3 insertions, 16 deletions
diff --git a/src/include/access/brin_revmap.h b/src/include/access/brin_revmap.h index 2ade88bc1e5..4351dcca1f8 100644 --- a/src/include/access/brin_revmap.h +++ b/src/include/access/brin_revmap.h @@ -31,7 +31,7 @@ extern void brinRevmapExtend(BrinRevmap *revmap, BlockNumber heapBlk); extern Buffer brinLockRevmapPageForUpdate(BrinRevmap *revmap, BlockNumber heapBlk); -extern void brinSetHeapBlockItemptr(Buffer rmbuf, BlockNumber pagesPerRange, +extern void brinSetHeapBlockItemptr(Buffer buf, BlockNumber pagesPerRange, BlockNumber heapBlk, ItemPointerData tid); extern BrinTuple *brinGetTupleForHeapBlock(BrinRevmap *revmap, BlockNumber heapBlk, Buffer *buf, OffsetNumber *off, diff --git a/src/include/access/hash_xlog.h b/src/include/access/hash_xlog.h index 53b682c56ef..7d52145a2a7 100644 --- a/src/include/access/hash_xlog.h +++ b/src/include/access/hash_xlog.h @@ -52,19 +52,6 @@ #define XLH_SPLIT_META_UPDATE_SPLITPOINT (1<<1) /* - * This is what we need to know about a HASH index create. - * - * Backup block 0: metapage - */ -typedef struct xl_hash_createidx -{ - double num_tuples; - RegProcedure procid; - uint16 ffactor; -} xl_hash_createidx; -#define SizeOfHashCreateIdx (offsetof(xl_hash_createidx, ffactor) + sizeof(uint16)) - -/* * This is what we need to know about simple (without split) insert. * * This data record is used for XLOG_HASH_INSERT diff --git a/src/include/access/reloptions.h b/src/include/access/reloptions.h index a1912f41e63..6d392e4d5a4 100644 --- a/src/include/access/reloptions.h +++ b/src/include/access/reloptions.h @@ -237,7 +237,7 @@ typedef struct /* * For use by code reading options already parsed: get a pointer to the string - * value itself. "optstruct" is the StdRdOption struct or equivalent, "member" + * value itself. "optstruct" is the StdRdOptions struct or equivalent, "member" * is the struct member corresponding to the string option */ #define GET_STRING_RELOPTION(optstruct, member) \ diff --git a/src/include/access/xlogreader.h b/src/include/access/xlogreader.h index a12c94cba67..aa9bc637259 100644 --- a/src/include/access/xlogreader.h +++ b/src/include/access/xlogreader.h @@ -248,7 +248,7 @@ extern bool DecodeXLogRecord(XLogReaderState *state, XLogRecord *record, extern FullTransactionId XLogRecGetFullXid(XLogReaderState *record); #endif -extern bool RestoreBlockImage(XLogReaderState *recoder, uint8 block_id, char *dst); +extern bool RestoreBlockImage(XLogReaderState *record, uint8 block_id, char *page); extern char *XLogRecGetBlockData(XLogReaderState *record, uint8 block_id, Size *len); extern bool XLogRecGetBlockTag(XLogReaderState *record, uint8 block_id, RelFileNode *rnode, ForkNumber *forknum, |