summaryrefslogtreecommitdiff
path: root/src/common
diff options
context:
space:
mode:
authorPeter Eisentraut2017-12-26 18:47:18 +0000
committerPeter Eisentraut2018-01-02 17:20:56 +0000
commit438036264a3b71eaf39b2d2eeca67237ed38ca51 (patch)
treec4fe35152c6ab32a3b661b8676b291a32f22304d /src/common
parent93ea78b17c4743c2b63edb5998fb5796ae57e289 (diff)
Don't cast between GinNullCategory and bool
The original idea was that we could use an isNull-style bool array directly as a GinNullCategory array. However, the existing code already acknowledges that that doesn't really work, because of the possibility that bool as currently defined can have arbitrary bit patterns for true values. So it has to loop through the nullFlags array to set each bool value to an acceptable value. But if we are looping through the whole array anyway, we might as well build a proper GinNullCategory array instead and abandon the type casting. That makes the code much safer in case bool is ever changed to something else. Reviewed-by: Michael Paquier <michael.paquier@gmail.com>
Diffstat (limited to 'src/common')
0 files changed, 0 insertions, 0 deletions