diff options
| author | Alvaro Herrera | 2020-05-12 20:01:52 +0000 |
|---|---|---|
| committer | Alvaro Herrera | 2020-05-12 20:07:30 +0000 |
| commit | 3e9744465dbe51822c7d76baca1f934d54ba9452 (patch) | |
| tree | 08526408599e7a83c122462413f793c0531576f4 /src/common/wchar.c | |
| parent | 6a918c3ac8a6b1d8b53cead6fcb7cbd84eee5750 (diff) | |
Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS
Use it at level 4, a bit more restrictive than the default level, and
tweak our commanding comments to FALLTHROUGH.
(However, leave zic.c alone, since it's external code; to avoid the
warnings that would appear there, change CFLAGS for that file in the
Makefile.)
Author: Julien Rouhaud <rjuju123@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20200412081825.qyo5vwwco3fv4gdo@nol
Discussion: https://postgr.es/m/flat/E1fDenm-0000C8-IJ@gemulon.postgresql.org
Diffstat (limited to 'src/common/wchar.c')
| -rw-r--r-- | src/common/wchar.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/common/wchar.c b/src/common/wchar.c index efaf1c155bb..352083d7bb1 100644 --- a/src/common/wchar.c +++ b/src/common/wchar.c @@ -1452,12 +1452,12 @@ pg_utf8_islegal(const unsigned char *source, int length) a = source[3]; if (a < 0x80 || a > 0xBF) return false; - /* FALL THRU */ + /* FALLTHROUGH */ case 3: a = source[2]; if (a < 0x80 || a > 0xBF) return false; - /* FALL THRU */ + /* FALLTHROUGH */ case 2: a = source[1]; switch (*source) @@ -1483,7 +1483,7 @@ pg_utf8_islegal(const unsigned char *source, int length) return false; break; } - /* FALL THRU */ + /* FALLTHROUGH */ case 1: a = *source; if (a >= 0x80 && a < 0xC2) |