diff options
| author | Peter Eisentraut | 2024-07-22 13:45:46 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2024-07-22 13:45:46 +0000 |
| commit | 5d2e1cc117b38db6bb5dc2e9ae9115304571ac70 (patch) | |
| tree | af2998a07a70e5cd70aef2e99a11d749764358c4 /src/common/logging.c | |
| parent | 90c1ba52e06d0847e524b6e6c3259ab1843bb05f (diff) | |
Replace some strtok() with strsep()
strtok() considers adjacent delimiters to be one delimiter, which is
arguably the wrong behavior in some cases. Replace with strsep(),
which has the right behavior: Adjacent delimiters create an empty
token.
Affected by this are parsing of:
- Stored SCRAM secrets
("SCRAM-SHA-256$<iterations>:<salt>$<storedkey>:<serverkey>")
- ICU collation attributes
("und@colStrength=primary;colCaseLevel=yes") for ICU older than
version 54
- PG_COLORS environment variable
("error=01;31:warning=01;35:note=01;36:locus=01")
- pg_regress command-line options with comma-separated list arguments
(--dbname, --create-role) (currently only used pg_regress_ecpg)
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: David Steele <david@pgmasters.net>
Discussion: https://www.postgresql.org/message-id/flat/79692bf9-17d3-41e6-b9c9-fc8c3944222a@eisentraut.org
Diffstat (limited to 'src/common/logging.c')
| -rw-r--r-- | src/common/logging.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/common/logging.c b/src/common/logging.c index e9a02e3e46a..aedd1ae2d8c 100644 --- a/src/common/logging.c +++ b/src/common/logging.c @@ -119,7 +119,9 @@ pg_logging_init(const char *argv0) if (colors) { - for (char *token = strtok(colors, ":"); token; token = strtok(NULL, ":")) + char *token; + + while ((token = strsep(&colors, ":"))) { char *e = strchr(token, '='); |