diff options
| author | Peter Eisentraut | 2022-09-16 07:37:54 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2022-09-16 07:41:33 +0000 |
| commit | c7db01e325a530ec38ec7ba57cd3ed32e123e33c (patch) | |
| tree | 699109735a34071a016940152cb6ab5e7960e74f /src/bin/scripts | |
| parent | cf2c7a736e4939ff0d6cf2acd29b17eea3bca7c2 (diff) | |
Don't allow creation of database with ICU locale with unsupported encoding
Check in CREATE DATABASE and initdb that the selected encoding is
supported by ICU. Before, they would pass but users would later get
an error from the server when they tried to use the database.
Also document that initdb sets the encoding to UTF8 by default if the
ICU locale provider is chosen.
Author: Marina Polyakova <m.polyakova@postgrespro.ru>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://www.postgresql.org/message-id/6dd6db0984d86a51b7255ba79f111971@postgrespro.ru
Diffstat (limited to 'src/bin/scripts')
| -rw-r--r-- | src/bin/scripts/t/020_createdb.pl | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/bin/scripts/t/020_createdb.pl b/src/bin/scripts/t/020_createdb.pl index e91c1d013d0..e95f200d0b9 100644 --- a/src/bin/scripts/t/020_createdb.pl +++ b/src/bin/scripts/t/020_createdb.pl @@ -50,6 +50,15 @@ if ($ENV{with_icu} eq 'yes') ], 'fails for invalid ICU locale'); + $node->command_fails_like( + [ + 'createdb', '-T', + 'template0', '--locale-provider=icu', + '--encoding=SQL_ASCII', 'foobarX' + ], + qr/ERROR: encoding "SQL_ASCII" is not supported with ICU provider/, + 'fails for encoding not supported by ICU'); + # additional node, which uses the icu provider my $node2 = PostgreSQL::Test::Cluster->new('icu'); $node2->init(extra => ['--locale-provider=icu', '--icu-locale=en']); |