diff options
| author | Michael Paquier | 2025-03-17 03:42:23 +0000 |
|---|---|---|
| committer | Michael Paquier | 2025-03-17 03:42:23 +0000 |
| commit | 19c6e92b13b2336d1db1b236457ab15d0894b506 (patch) | |
| tree | 672b72d1e75f47fbbe28db3326267804c6af6dcf /src/bin/pgbench | |
| parent | 5721e5453ebc59360b6756fe72d7499c4a02177c (diff) | |
Apply more consistent style for command options in TAP tests
This commit reshapes the grammar of some commands to apply a more
consistent style across the board, following rules similar to
ce1b0f9da03e:
- Elimination of some pointless used-once variables.
- Use of long options, to self-document better the options used.
- Use of fat commas to link option names and their assigned values,
including redirections, so as perltidy can be tricked to put them
together.
Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://postgr.es/m/87jz8rzf3h.fsf@wibble.ilmari.org
Diffstat (limited to 'src/bin/pgbench')
| -rw-r--r-- | src/bin/pgbench/t/001_pgbench_with_server.pl | 2 | ||||
| -rw-r--r-- | src/bin/pgbench/t/002_pgbench_no_server.pl | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl index 8816af17ac1..7dd78940300 100644 --- a/src/bin/pgbench/t/001_pgbench_with_server.pl +++ b/src/bin/pgbench/t/001_pgbench_with_server.pl @@ -213,7 +213,7 @@ my $nthreads = 2; { my ($stderr); - run_log([ 'pgbench', '--jobs' => '2', '--bad-option' ], '2>', \$stderr); + run_log([ 'pgbench', '--jobs' => '2', '--bad-option' ], '2>' => \$stderr); $nthreads = 1 if $stderr =~ m/threads are not supported on this platform/; } diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl index ea6677f90e1..f975c73dd75 100644 --- a/src/bin/pgbench/t/002_pgbench_no_server.pl +++ b/src/bin/pgbench/t/002_pgbench_no_server.pl @@ -50,7 +50,7 @@ sub pgbench_scripts # cleanup from prior runs unlink $filename; append_to_file($filename, $$files{$fn}); - push @cmd, '-f', $filename; + push @cmd, '--file' => $filename; } } command_checks_all(\@cmd, $stat, $out, $err, $name); |