diff options
| author | Michael Paquier | 2020-07-11 04:32:28 +0000 |
|---|---|---|
| committer | Michael Paquier | 2020-07-11 04:32:28 +0000 |
| commit | cc35d8933a211d9965eb1c1d2749a903d5735db2 (patch) | |
| tree | aa94cde941781ec163a7549ae20ae53cfdea72b6 /src/backend/tcop | |
| parent | df646509f371069c65f84309eb5749642e8650b3 (diff) | |
Rename field "relkind" to "objtype" for CTAS and ALTER TABLE nodes
"relkind" normally refers to the char field from pg_class. However, in
the parse nodes AlterTableStmt and CreateTableAsStmt, "relkind" was used
for a field of type enum ObjectType, that could refer to other object
types than those possible for a relkind. Such fields being usually
named "objtype", switch the name in both structures to make things more
consistent. Note that this led to some confusion in functions that
also operate on a RangeTableEntry object, which also has a field named
"relkind".
This naming goes back to commit 09d4e96, where only OBJECT_TABLE and
OBJECT_INDEX were used. This got extended later to use as well
OBJECT_TYPE with e440e12, not really a relation kind.
Author: Mark Dilger
Reviewed-by: Daniel Gustafsson, Álvaro Herrera, Michael Paquier
Discussion: https://postgr.es/m/609181AE-E399-47C7-9221-856E0F96BF93@enterprisedb.com
Diffstat (limited to 'src/backend/tcop')
| -rw-r--r-- | src/backend/tcop/utility.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c index 97cbaa3072b..9b0c376c8cb 100644 --- a/src/backend/tcop/utility.c +++ b/src/backend/tcop/utility.c @@ -2574,7 +2574,7 @@ CreateCommandTag(Node *parsetree) break; case T_AlterTableStmt: - tag = AlterObjectTypeCommandTag(((AlterTableStmt *) parsetree)->relkind); + tag = AlterObjectTypeCommandTag(((AlterTableStmt *) parsetree)->objtype); break; case T_AlterDomainStmt: @@ -2752,7 +2752,7 @@ CreateCommandTag(Node *parsetree) break; case T_CreateTableAsStmt: - switch (((CreateTableAsStmt *) parsetree)->relkind) + switch (((CreateTableAsStmt *) parsetree)->objtype) { case OBJECT_TABLE: if (((CreateTableAsStmt *) parsetree)->is_select_into) |