diff options
| author | Tom Lane | 2001-08-10 18:57:42 +0000 |
|---|---|---|
| committer | Tom Lane | 2001-08-10 18:57:42 +0000 |
| commit | bf56f0759bdfa87f143c3abd09f893a5f530fe88 (patch) | |
| tree | 10555a5e46bcfdfd9799b8f0e13ab48101d766de /src/backend/rewrite | |
| parent | d062f0f4e91f68b1f55b04691bd92d1efc83dc54 (diff) | |
Make OIDs optional, per discussions in pghackers. WITH OIDS is still the
default, but OIDS are removed from many system catalogs that don't need them.
Some interesting side effects: TOAST pointers are 20 bytes not 32 now;
pg_description has a three-column key instead of one.
Bugs fixed in passing: BINARY cursors work again; pg_class.relhaspkey
has some usefulness; pg_dump dumps comments on indexes, rules, and
triggers in a valid order.
initdb forced.
Diffstat (limited to 'src/backend/rewrite')
| -rw-r--r-- | src/backend/rewrite/rewriteRemove.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/backend/rewrite/rewriteRemove.c b/src/backend/rewrite/rewriteRemove.c index 15e3434721a..92326d93b6d 100644 --- a/src/backend/rewrite/rewriteRemove.c +++ b/src/backend/rewrite/rewriteRemove.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteRemove.c,v 1.44 2001/03/22 03:59:44 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteRemove.c,v 1.45 2001/08/10 18:57:37 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -119,7 +119,7 @@ RemoveRewriteRule(char *ruleName) /* * Delete any comments associated with this rule */ - DeleteComments(ruleId); + DeleteComments(ruleId, RelationGetRelid(RewriteRelation)); /* * Now delete the pg_rewrite tuple for the rule @@ -175,10 +175,8 @@ RelationRemoveRules(Oid relid) while (HeapTupleIsValid(tuple = heap_getnext(scanDesc, 0))) { - - /*** Delete any comments associated with this relation ***/ - - DeleteComments(tuple->t_data->t_oid); + /* Delete any comments associated with this rule */ + DeleteComments(tuple->t_data->t_oid, RelationGetRelid(RewriteRelation)); simple_heap_delete(RewriteRelation, &tuple->t_self); } |