Make ALTER TABLE RENAME on a view rename the view's on-select rule too.

Needed to keep pg_dump from getting confused.

2 files changed, 89 insertions, 3 deletions

diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c
index 4cebece58cd..b0315157e4f 100644
--- a/src/backend/rewrite/rewriteDefine.c
+++ b/src/backend/rewrite/rewriteDefine.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.62 2001/05/03 21:16:48 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.63 2001/08/12 21:35:18 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -28,6 +28,7 @@
 #include "rewrite/rewriteSupport.h"
 #include "storage/smgr.h"
 #include "utils/builtins.h"
+#include "utils/syscache.h"
 
 
 static void setRuleCheckAsUser(Query *qry, Oid userid);
@@ -478,3 +479,51 @@ setRuleCheckAsUser_walker(Node *node, Oid *context)
 	return expression_tree_walker(node, setRuleCheckAsUser_walker,
 								  (void *) context);
 }
+
+
+/*
+ * Rename an existing rewrite rule.
+ *
+ * There is not currently a user command to invoke this directly
+ * (perhaps there should be).  But we need it anyway to rename the
+ * ON SELECT rule associated with a view, when the view is renamed.
+ */
+void
+RenameRewriteRule(char *oldname, char *newname)
+{
+	Relation	pg_rewrite_desc;
+	HeapTuple	ruletup;
+
+	pg_rewrite_desc = heap_openr(RewriteRelationName, RowExclusiveLock);
+
+	ruletup = SearchSysCacheCopy(RULENAME,
+								 PointerGetDatum(oldname),
+								 0, 0, 0);
+	if (!HeapTupleIsValid(ruletup))
+		elog(ERROR, "RenameRewriteRule: rule \"%s\" does not exist", oldname);
+
+	/* should not already exist */
+	if (IsDefinedRewriteRule(newname))
+		elog(ERROR, "Attempt to rename rule \"%s\" failed: \"%s\" already exists",
+			 oldname, newname);
+
+	StrNCpy(NameStr(((Form_pg_rewrite) GETSTRUCT(ruletup))->rulename),
+			newname, NAMEDATALEN);
+
+	simple_heap_update(pg_rewrite_desc, &ruletup->t_self, ruletup);
+
+	/* keep system catalog indices current */
+	if (RelationGetForm(pg_rewrite_desc)->relhasindex)
+	{
+		Relation	idescs[Num_pg_rewrite_indices];
+
+		CatalogOpenIndices(Num_pg_rewrite_indices, Name_pg_rewrite_indices,
+						   idescs);
+		CatalogIndexInsert(idescs, Num_pg_rewrite_indices, pg_rewrite_desc,
+						   ruletup);
+		CatalogCloseIndices(Num_pg_rewrite_indices, idescs);
+	}
+
+	heap_freetuple(ruletup);
+	heap_close(pg_rewrite_desc, RowExclusiveLock);
+}
diff --git a/src/backend/rewrite/rewriteSupport.c b/src/backend/rewrite/rewriteSupport.c
index 7578acbcedd..bc2f04932a4 100644
--- a/src/backend/rewrite/rewriteSupport.c
+++ b/src/backend/rewrite/rewriteSupport.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteSupport.c,v 1.48 2001/03/22 03:59:44 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteSupport.c,v 1.49 2001/08/12 21:35:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -20,9 +20,16 @@
 #include "rewrite/rewriteSupport.h"
 #include "utils/syscache.h"
 
+#ifdef MULTIBYTE
+#include "mb/pg_wchar.h"
+#endif
 
+
+/*
+ * Is there a rule by the given name?
+ */
 bool
-IsDefinedRewriteRule(char *ruleName)
+IsDefinedRewriteRule(const char *ruleName)
 {
 	return SearchSysCacheExists(RULENAME,
 								PointerGetDatum(ruleName),
@@ -30,6 +37,36 @@ IsDefinedRewriteRule(char *ruleName)
 }
 
 /*
+ * makeViewRetrieveRuleName
+ *
+ * Given a view name, returns the name for the associated ON SELECT rule.
+ *
+ * XXX this is not the only place in the backend that knows about the _RET
+ * name-forming convention.
+ */
+char *
+MakeRetrieveViewRuleName(const char *viewName)
+{
+	char	   *buf;
+	int			buflen,
+				maxlen;
+
+	buflen = strlen(viewName) + 5;
+	buf = palloc(buflen);
+	snprintf(buf, buflen, "_RET%s", viewName);
+	/* clip to less than NAMEDATALEN bytes, if necessary */
+#ifdef MULTIBYTE
+	maxlen = pg_mbcliplen(buf, strlen(buf), NAMEDATALEN - 1);
+#else
+	maxlen = NAMEDATALEN - 1;
+#endif
+	if (maxlen < buflen)
+		buf[maxlen] = '\0';
+
+	return buf;
+}
+
+/*
  * SetRelationRuleStatus
  *		Set the value of the relation's relhasrules field in pg_class;
  *		if the relation is becoming a view, also adjust its relkind.