diff options
| author | Tom Lane | 2024-05-20 19:08:30 +0000 |
|---|---|---|
| committer | Tom Lane | 2024-05-20 19:08:30 +0000 |
| commit | 7204f35919b7e021e8d1bc9f2d76fd6bfcdd2070 (patch) | |
| tree | d9a6ed2112d569e2c6b52eb60773c8524b37f1b2 /src/backend/parser | |
| parent | d2a04470aa6401c1938cc107e0b2c56c22a2321f (diff) | |
Revert commit 66c0185a3 and follow-on patches.
This reverts 66c0185a3 (Allow planner to use Merge Append to
efficiently implement UNION) as well as the follow-on commits
d5d2205c8, 3b1a7eb28, 7487044d6. In addition to those, 07746a8ef
had to be removed then re-applied in a different place, because
66c0185a3 moved the relevant code.
The reason for this last-minute thrashing is that depesz found a
case in which the patched code creates a completely wrong plan
that silently gives incorrect query results. It's unclear what
the cause is or how many cases are affected, but with beta1 wrap
staring us in the face, there's no time for closer investigation.
After we figure that out, we can decide whether to un-revert this
for beta2 or hold it for v18.
Discussion: https://postgr.es/m/Zktzf926vslR35Fv@depesz.com
(also some private discussion among pgsql-release)
Diffstat (limited to 'src/backend/parser')
| -rw-r--r-- | src/backend/parser/analyze.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c index 28fed9d87f6..40ea19e6f10 100644 --- a/src/backend/parser/analyze.c +++ b/src/backend/parser/analyze.c @@ -1890,8 +1890,7 @@ transformSetOperationStmt(ParseState *pstate, SelectStmt *stmt) * For now, we don't support resjunk sort clauses on the output of a * setOperation tree --- you can only use the SQL92-spec options of * selecting an output column by name or number. Enforce by checking that - * transformSortClause doesn't add any items to tlist. Note, if changing - * this, add_setop_child_rel_equivalences() will need to be updated. + * transformSortClause doesn't add any items to tlist. */ tllen = list_length(qry->targetList); |