diff options
| author | Álvaro Herrera | 2025-03-27 12:33:37 +0000 |
|---|---|---|
| committer | Álvaro Herrera | 2025-03-27 12:33:37 +0000 |
| commit | 9fbd53dea5d513a78ca04834101ca1aa73b63e59 (patch) | |
| tree | 6d7bedd62113958f907c20e6cabd8649c740947d /src/backend/nodes | |
| parent | 5d5f415816a60a3c5c5e4420eff55e73edfbd9f5 (diff) | |
Remove the query_id_squash_values GUC
Commit 62d712ecfd94 introduced the capability to calculate the same
queryId for queries with different lengths of constants in a list for an
IN clause. This behavior was originally enabled with a GUC
query_id_squash_values. After a discussion about the value of such a
GUC, it was decided to back out of the use of a GUC and make the
squashing behavior the only available option.
Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/Z-LZyygkkNyA8-kR@msg.df7cb.de
Discussion: https://postgr.es/m/CA+q6zcVTK-3C-8NWV1oY2NZrvtnMCDqnyYYyk1T7WMUG65MeOQ@mail.gmail.com
Diffstat (limited to 'src/backend/nodes')
| -rw-r--r-- | src/backend/nodes/queryjumblefuncs.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/src/backend/nodes/queryjumblefuncs.c b/src/backend/nodes/queryjumblefuncs.c index 1d9abd89028..513cf92d357 100644 --- a/src/backend/nodes/queryjumblefuncs.c +++ b/src/backend/nodes/queryjumblefuncs.c @@ -46,9 +46,6 @@ /* GUC parameters */ int compute_query_id = COMPUTE_QUERY_ID_AUTO; -/* Whether to merge constants in a list when computing query_id */ -bool query_id_squash_values = false; - /* * True when compute_query_id is ON or AUTO, and a module requests them. * @@ -472,7 +469,7 @@ IsSquashableConstList(List *elements, Node **firstExpr, Node **lastExpr) * If squashing is disabled, or the list is too short, we don't try to * squash it. */ - if (!query_id_squash_values || list_length(elements) < 2) + if (list_length(elements) < 2) return false; foreach(temp, elements) @@ -520,13 +517,10 @@ do { \ #include "queryjumblefuncs.funcs.c" /* - * When query_id_squash_values is enabled, we jumble lists of constant - * elements as one individual item regardless of how many elements are - * in the list. This means different queries jumble to the same query_id, - * if the only difference is the number of elements in the list. - * - * If query_id_squash_values is disabled or the list is not "simple - * enough", we jumble each element normally. + * We jumble lists of constant elements as one individual item regardless + * of how many elements are in the list. This means different queries + * jumble to the same query_id, if the only difference is the number of + * elements in the list. */ static void _jumbleElements(JumbleState *jstate, List *elements) |