diff options
| author | Bruce Momjian | 1998-03-30 16:47:35 +0000 |
|---|---|---|
| committer | Bruce Momjian | 1998-03-30 16:47:35 +0000 |
| commit | 9a0dd4fb183958f59f68d8a5f096dd8df18d9b59 (patch) | |
| tree | 2843356dbd25f4e11cf4a414e56d6afae3775071 /src/backend/libpq | |
| parent | c579ce0fb03aaf92d184adf369cf13be013adf1b (diff) | |
There's a patch attached to fix gcc 2.8.x warnings, except for the
yyerror ones from bison. It also includes a few 'enhancements' to
the C programming style (which are, of course, personal).
The other patch removes the compilation of backend/lib/qsort.c, as
qsort() is a standard function in stdlib.h and can be used any
where else (and it is). It was only used in
backend/optimizer/geqo/geqo_pool.c, backend/optimizer/path/predmig.c,
and backend/storage/page/bufpage.c
> > Some or all of these changes might not be appropriate for v6.3,
since we > > are in beta testing and since they do not affect the
current functionality. > > For those cases, how about submitting
patches based on the final v6.3 > > release?
There's more to come. Please review these patches. I ran the
regression tests and they only failed where this was expected
(random, geo, etc).
Cheers,
Jeroen
Diffstat (limited to 'src/backend/libpq')
| -rw-r--r-- | src/backend/libpq/be-dumpdata.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/libpq/be-dumpdata.c b/src/backend/libpq/be-dumpdata.c index 9ac6af1d1f0..2a7df53ee6b 100644 --- a/src/backend/libpq/be-dumpdata.c +++ b/src/backend/libpq/be-dumpdata.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/libpq/Attic/be-dumpdata.c,v 1.14 1998/02/26 04:31:44 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/libpq/Attic/be-dumpdata.c,v 1.15 1998/03/30 16:46:29 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -305,10 +305,12 @@ be_printtup(HeapTuple tuple, TupleDesc typeinfo) lengths[i] = typeinfo->attrs[i]->attlen; if (lengths[i] == -1) /* variable length attribute */ + { if (!isnull) lengths[i] = VARSIZE(attr) - VARHDRSZ; else lengths[i] = 0; + } if (!isnull && OidIsValid(typoutput)) { |