diff options
| author | Andres Freund | 2019-06-11 06:20:48 +0000 |
|---|---|---|
| committer | Andres Freund | 2019-06-11 06:36:55 +0000 |
| commit | b8607e15e0fa0a3ac20779e39eea24fd67ebb650 (patch) | |
| tree | 0d2df947c75cdecc1fc1fe7d149955c727ceeba2 /doc/src | |
| parent | 959792087a10baf7f1b58408d28411109bcedb7a (diff) | |
Don't access catalogs to validate GUCs when not connected to a DB.
Vignesh found this bug in the check function for
default_table_access_method's check hook, but that was just copied
from older GUCs. Investigation by Michael and me then found the bug in
further places.
When not connected to a database (e.g. in a walsender connection), we
cannot perform (most) GUC checks that need database access. Even when
only shared tables are needed, unless they're
nailed (c.f. RelationCacheInitializePhase2()), they cannot be accessed
without pg_class etc. being present.
Fix by extending the existing IsTransactionState() checks to also
check for MyDatabaseOid.
Reported-By: Vignesh C, Michael Paquier, Andres Freund
Author: Vignesh C, Andres Freund
Discussion: https://postgr.es/m/CALDaNm1KXK9gbZfY-p_peRFm_XrBh1OwQO1Kk6Gig0c0fVZ2uw%40mail.gmail.com
Backpatch: 9.4-
Diffstat (limited to 'doc/src')
0 files changed, 0 insertions, 0 deletions