diff options
| author | Tom Lane | 2022-01-17 18:30:04 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-01-17 18:30:04 +0000 |
| commit | 92e6c1c9be159e5f46b11465200ac08965c225b9 (patch) | |
| tree | 2749bb84435c3133062df2318e09429c30815a8c /doc/src | |
| parent | 8b107467c632705b739e1b27795af32de6f14d15 (diff) | |
Avoid calling gettext() in signal handlers.
It seems highly unlikely that gettext() can be relied on to be
async-signal-safe. psql used to understand that, but someone got
it wrong long ago in the src/bin/scripts/ version of handle_sigint,
and then the bad idea was perpetuated when those two versions were
unified into src/fe_utils/cancel.c.
I'm unsure why there have not been field complaints about this
... maybe gettext() is signal-safe once it's translated at least
one message? But we have no business assuming any such thing.
In cancel.c (v13 and up), I preserved our ability to localize
"Cancel request sent" messages by invoking gettext() before
the signal handler is set up. In earlier branches I just made
src/bin/scripts/ not localize those messages, as psql did then.
(Just for extra unsafety, the src/bin/scripts/ version was
invoking fprintf() from a signal handler. Sigh.)
Noted while fixing signal-safety issues in PQcancel() itself.
Back-patch to all supported branches.
Discussion: https://postgr.es/m/2937814.1641960929@sss.pgh.pa.us
Diffstat (limited to 'doc/src')
0 files changed, 0 insertions, 0 deletions