diff options
| author | Bruce Momjian | 2002-08-14 05:49:22 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2002-08-14 05:49:22 +0000 |
| commit | dec918479ff8aec20f531a88f53b71fecba4067a (patch) | |
| tree | 1fe7c0c583409a752d4e869139751ef10ef238ee /doc/TODO | |
| parent | 538b1015958dbbe447434909a6412e79d4298643 (diff) | |
I guess I'd vote for changing the code to be
sys = malloc(strlen(editorName) + strlen(fname) + 10 + 1);
if (!sys)
return false;
sprintf(sys, "exec '%s' '%s'", editorName, fname);
(note the added quotes to provide a little protection against spaces
and such). Then it's perfectly obvious what the calculation is doing.
I don't care about wasting 20-some bytes, but confusing readers of the
code is worth avoiding.
regards, tom lane
Diffstat (limited to 'doc/TODO')
| -rw-r--r-- | doc/TODO | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -1,6 +1,6 @@ TODO list for PostgreSQL ======================== -Last updated: Wed Aug 14 00:57:54 EDT 2002 +Last updated: Wed Aug 14 01:46:11 EDT 2002 Current maintainer: Bruce Momjian (pgman@candle.pha.pa.us) @@ -205,7 +205,8 @@ Commands o Add ALTER TABLE tab SET WITHOUT OIDS * CLUSTER - o Cluster all tables at once + o Cluster all tables at once using pg_index.indisclustered or primary + key o Prevent loss of indexes, permissions, inheritance o Automatically maintain clustering on a table |