Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.

It was never terribly consistent to use OR REPLACE (because of the lack of
comparable functionality for data types, operators, etc), and
experimentation shows that it's now positively pernicious in the extension
world.  We really want a failure to occur if there are any conflicts, else
it's unclear what the extension-ownership state of the conflicted object
ought to be.  Most of the time, CREATE EXTENSION will fail anyway because
of conflicts on other object types, but an extension defining only
functions can succeed, with bad results.

1 files changed, 9 insertions, 9 deletions

diff --git a/contrib/sslinfo/sslinfo--1.0.sql b/contrib/sslinfo/sslinfo--1.0.sql
index 37007e59f7c..ef745a0a2e6 100644
--- a/contrib/sslinfo/sslinfo--1.0.sql
+++ b/contrib/sslinfo/sslinfo--1.0.sql
@@ -1,37 +1,37 @@
 /* contrib/sslinfo/sslinfo--1.0.sql */
 
-CREATE OR REPLACE FUNCTION ssl_client_serial() RETURNS numeric
+CREATE FUNCTION ssl_client_serial() RETURNS numeric
 AS 'MODULE_PATHNAME', 'ssl_client_serial'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_is_used() RETURNS boolean
+CREATE FUNCTION ssl_is_used() RETURNS boolean
 AS 'MODULE_PATHNAME', 'ssl_is_used'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_version() RETURNS text
+CREATE FUNCTION ssl_version() RETURNS text
 AS 'MODULE_PATHNAME', 'ssl_version'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_cipher() RETURNS text
+CREATE FUNCTION ssl_cipher() RETURNS text
 AS 'MODULE_PATHNAME', 'ssl_cipher'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_client_cert_present() RETURNS boolean
+CREATE FUNCTION ssl_client_cert_present() RETURNS boolean
 AS 'MODULE_PATHNAME', 'ssl_client_cert_present'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_client_dn_field(text) RETURNS text
+CREATE FUNCTION ssl_client_dn_field(text) RETURNS text
 AS 'MODULE_PATHNAME', 'ssl_client_dn_field'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_issuer_field(text) RETURNS text
+CREATE FUNCTION ssl_issuer_field(text) RETURNS text
 AS 'MODULE_PATHNAME', 'ssl_issuer_field'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_client_dn() RETURNS text
+CREATE FUNCTION ssl_client_dn() RETURNS text
 AS 'MODULE_PATHNAME', 'ssl_client_dn'
 LANGUAGE C STRICT;
 
-CREATE OR REPLACE FUNCTION ssl_issuer_dn() RETURNS text
+CREATE FUNCTION ssl_issuer_dn() RETURNS text
 AS 'MODULE_PATHNAME', 'ssl_issuer_dn'
 LANGUAGE C STRICT;