diff options
| author | Tom Lane | 2020-04-16 18:45:54 +0000 |
|---|---|---|
| committer | Tom Lane | 2020-04-16 18:45:54 +0000 |
| commit | fc576b7c4f3a5f045d443fc771d9e0f54b33e72b (patch) | |
| tree | b657c676c1e90c2b6f379bb9351c98aa4f3d6f4b /contrib/sepgsql/sql | |
| parent | 24d2d38b1eb86c0b410ad0f07f66566a83c6f05c (diff) | |
Fix cache reference leak in contrib/sepgsql.
fixup_whole_row_references() did the wrong thing with a dropped column,
resulting in a commit-time warning about a cache reference leak.
I (tgl) added a test case exercising this, but back-patched the test
only as far as v10; the patch didn't apply cleanly to 9.6 and it
didn't seem worth the trouble to adapt it. The bug is pretty old
though, so apply the code change all the way back.
Michael Luo, with cosmetic improvements by me
Discussion: https://postgr.es/m/BYAPR08MB5606D1453D7F50E2AF4D2FD29AD80@BYAPR08MB5606.namprd08.prod.outlook.com
Diffstat (limited to 'contrib/sepgsql/sql')
| -rw-r--r-- | contrib/sepgsql/sql/dml.sql | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/contrib/sepgsql/sql/dml.sql b/contrib/sepgsql/sql/dml.sql index 19201f4b90b..4a47b4a3c62 100644 --- a/contrib/sepgsql/sql/dml.sql +++ b/contrib/sepgsql/sql/dml.sql @@ -5,8 +5,9 @@ -- -- Setup -- -CREATE TABLE t1 (a int, b text); +CREATE TABLE t1 (a int, junk int, b text); SECURITY LABEL ON TABLE t1 IS 'system_u:object_r:sepgsql_table_t:s0'; +ALTER TABLE t1 DROP COLUMN junk; INSERT INTO t1 VALUES (1, 'aaa'), (2, 'bbb'), (3, 'ccc'); CREATE TABLE t2 (x int, y text); @@ -17,8 +18,9 @@ CREATE TABLE t3 (s int, t text); SECURITY LABEL ON TABLE t3 IS 'system_u:object_r:sepgsql_fixed_table_t:s0'; INSERT INTO t3 VALUES (1, 'sss'), (2, 'ttt'), (3, 'uuu'); -CREATE TABLE t4 (m int, n text); +CREATE TABLE t4 (m int, junk int, n text); SECURITY LABEL ON TABLE t4 IS 'system_u:object_r:sepgsql_secret_table_t:s0'; +ALTER TABLE t4 DROP COLUMN junk; INSERT INTO t4 VALUES (1, 'mmm'), (2, 'nnn'), (3, 'ooo'); CREATE TABLE t5 (e text, f text, g text); @@ -95,6 +97,8 @@ SELECT * FROM t3; -- ok SELECT * FROM t4; -- failed SELECT * FROM t5; -- failed SELECT e,f FROM t5; -- ok +SELECT (t1.*)::record FROM t1; -- ok +SELECT (t4.*)::record FROM t4; -- failed --- -- partitioned table parent |