diff options
| author | Tom Lane | 2022-12-21 22:51:50 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-12-21 22:51:50 +0000 |
| commit | 701c881f782b93ee29587112390bd3bfe035e78d (patch) | |
| tree | 9c6fa26811eb5060846fcc75bb0bda3141c028ab /contrib/seg/sql | |
| parent | 33dd895ef3316bd1896def6882e9075359d7e9af (diff) | |
Fix contrib/seg to be more wary of long input numbers.
seg stores the number of significant digits in an input number
in a "char" field. If char is signed, and the input is more than
127 digits long, the count can read out as negative causing
seg_out() to print garbage (or, if you're really unlucky,
even crash).
To fix, clamp the digit count to be not more than FLT_DIG.
(In theory this loses some information about what the original
input was, but it doesn't seem like useful information; it would
not survive dump/restore in any case.)
Also, in case there are stored values of the seg type containing
bad data, add a clamp in seg_out's restore() subroutine.
Per bug #17725 from Robins Tharakan. It's been like this
forever, so back-patch to all supported branches.
Discussion: https://postgr.es/m/17725-0a09313b67fbe86e@postgresql.org
Diffstat (limited to 'contrib/seg/sql')
| -rw-r--r-- | contrib/seg/sql/seg.sql | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/contrib/seg/sql/seg.sql b/contrib/seg/sql/seg.sql index 6fe33e90e4e..a027d4de97e 100644 --- a/contrib/seg/sql/seg.sql +++ b/contrib/seg/sql/seg.sql @@ -60,6 +60,9 @@ SELECT '3.400e5'::seg AS seg; -- Digits truncated SELECT '12.34567890123456'::seg AS seg; +-- Same, with a very long input +SELECT '12.3456789012345600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'::seg AS seg; + -- Numbers with certainty indicators SELECT '~6.5'::seg AS seg; SELECT '<6.5'::seg AS seg; |