Modify hash_create() to elog(ERROR) if an error occurs, rather than

returning a NULL pointer (some callers remembered to check the return
value, but some did not -- it is safer to just bail out).

Also, cleanup pgstat.c to use elog(ERROR) rather than elog(LOG) followed
by exit().

1 files changed, 1 insertions, 9 deletions

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 2b33043c5a2..f6c95ef1dcd 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -2043,19 +2043,11 @@ static HTAB *
 createConnHash(void)
 {
 	HASHCTL		ctl;
-	HTAB	   *ptr;
 
 	ctl.keysize = NAMEDATALEN;
 	ctl.entrysize = sizeof(remoteConnHashEnt);
 
-	ptr = hash_create("Remote Con hash", NUMCONN, &ctl, HASH_ELEM);
-
-	if (!ptr)
-		ereport(ERROR,
-				(errcode(ERRCODE_OUT_OF_MEMORY),
-				 errmsg("out of memory")));
-
-	return (ptr);
+	return hash_create("Remote Con hash", NUMCONN, &ctl, HASH_ELEM);
 }
 
 static void