Attached is an update to contrib/dblink. Please apply if there are no

objections.

Major changes:
   - removed cursor wrap around input sql to allow for remote
     execution of INSERT/UPDATE/DELETE
   - dblink now returns a resource id instead of a real pointer
   - added several utility functions

I'm still hoping to add explicit cursor open/fetch/close support before
7.3 is released, but I need a bit more time on that.

On a somewhat unrelated topic, I never got any feedback on the
unknownin/out patch and the mb_substring patch. Is there anything else I
need to do to get those applied?

Joe Conway

1 files changed, 37 insertions, 4 deletions

diff --git a/contrib/dblink/dblink.sql.in b/contrib/dblink/dblink.sql.in
index 1615c004135..6b567b8cd51 100644
--- a/contrib/dblink/dblink.sql.in
+++ b/contrib/dblink/dblink.sql.in
@@ -1,5 +1,38 @@
-CREATE FUNCTION dblink (text,text) RETURNS setof int
-  AS 'MODULE_PATHNAME','dblink' LANGUAGE 'c';
+CREATE OR REPLACE FUNCTION dblink (text,text) RETURNS setof int
+  AS 'MODULE_PATHNAME','dblink' LANGUAGE 'c'
+  WITH (isstrict);
 
-CREATE FUNCTION dblink_tok (int,int) RETURNS text
-  AS 'MODULE_PATHNAME','dblink_tok' LANGUAGE 'c';
+CREATE OR REPLACE FUNCTION dblink_tok (int,int) RETURNS text
+  AS 'MODULE_PATHNAME','dblink_tok' LANGUAGE 'c'
+  WITH (isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_strtok (text,text,int) RETURNS text
+  AS 'MODULE_PATHNAME','dblink_strtok' LANGUAGE 'c'
+  WITH (iscachable, isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_get_pkey (name) RETURNS setof text
+  AS 'MODULE_PATHNAME','dblink_get_pkey' LANGUAGE 'c'
+  WITH (isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_last_oid (int) RETURNS oid
+  AS 'MODULE_PATHNAME','dblink_last_oid' LANGUAGE 'c'
+  WITH (isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_build_sql_insert (name, int2vector, int2, _text, _text) RETURNS text
+  AS 'MODULE_PATHNAME','dblink_build_sql_insert' LANGUAGE 'c'
+  WITH (isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_build_sql_delete (name, int2vector, int2, _text) RETURNS text
+  AS 'MODULE_PATHNAME','dblink_build_sql_delete' LANGUAGE 'c'
+  WITH (isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_build_sql_update (name, int2vector, int2, _text, _text) RETURNS text
+  AS 'MODULE_PATHNAME','dblink_build_sql_update' LANGUAGE 'c'
+  WITH (isstrict);
+
+CREATE OR REPLACE FUNCTION dblink_current_query () RETURNS text
+  AS 'MODULE_PATHNAME','dblink_current_query' LANGUAGE 'c';
+
+CREATE OR REPLACE FUNCTION dblink_replace (text,text,text) RETURNS text
+  AS 'MODULE_PATHNAME','dblink_replace_text' LANGUAGE 'c'
+  WITH (iscachable, isstrict);