diff options
| author | Tom Lane | 2022-02-03 04:01:56 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-02-03 04:01:56 +0000 |
| commit | 4b0e37faaf5ffe1552a07438323341c6394890da (patch) | |
| tree | c24069feb0ccbda5de592cf292e27cfd07e0e01f /configure | |
| parent | 9d179d9c23b9d4cc1a4ffa02e4de79114de064d7 (diff) | |
Remove configure's check for rl_completion_append_character.
The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1
don't have rl_completion_append_character". It seems certain that such
versions are extinct in the wild, though; for sure there are none in the
buildfarm. Libedit has had this variable for at least twenty years too.
Also, tab-complete.c's behavior without it is quite unfriendly, since
we'll emit a space even when completion fails; but we've had no
complaints about that.
Therefore, let's assume this variable is always there, and drop the
configure check to save a few build cycles.
Discussion: https://postgr.es/m/147685.1643858911@sss.pgh.pa.us
Diffstat (limited to 'configure')
| -rwxr-xr-x | configure | 41 |
1 files changed, 1 insertions, 40 deletions
diff --git a/configure b/configure index 93a46a859b7..879f92202f3 100755 --- a/configure +++ b/configure @@ -17006,46 +17006,7 @@ fi LIBS="$LIBS_including_readline" if test "$with_readline" = yes; then - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for rl_completion_append_character" >&5 -$as_echo_n "checking for rl_completion_append_character... " >&6; } -if ${pgac_cv_var_rl_completion_append_character+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ -#include <stdio.h> -#if defined(HAVE_READLINE_READLINE_H) -#include <readline/readline.h> -#elif defined(HAVE_EDITLINE_READLINE_H) -#include <editline/readline.h> -#elif defined(HAVE_READLINE_H) -#include <readline.h> -#endif - -int -main () -{ -rl_completion_append_character = 'x'; - ; - return 0; -} -_ACEOF -if ac_fn_c_try_link "$LINENO"; then : - pgac_cv_var_rl_completion_append_character=yes -else - pgac_cv_var_rl_completion_append_character=no -fi -rm -f core conftest.err conftest.$ac_objext \ - conftest$ac_exeext conftest.$ac_ext -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $pgac_cv_var_rl_completion_append_character" >&5 -$as_echo "$pgac_cv_var_rl_completion_append_character" >&6; } -if test x"$pgac_cv_var_rl_completion_append_character" = x"yes"; then - -$as_echo "#define HAVE_RL_COMPLETION_APPEND_CHARACTER 1" >>confdefs.h - -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for rl_completion_suppress_quote" >&5 + { $as_echo "$as_me:${as_lineno-$LINENO}: checking for rl_completion_suppress_quote" >&5 $as_echo_n "checking for rl_completion_suppress_quote... " >&6; } if ${pgac_cv_var_rl_completion_suppress_quote+:} false; then : $as_echo_n "(cached) " >&6 |