diff options
| author | Tom Lane | 2016-03-14 14:41:29 +0000 |
|---|---|---|
| committer | Tom Lane | 2016-03-14 14:41:29 +0000 |
| commit | bf53d5c208a3bdce243a38666fc50f5418c78c3b (patch) | |
| tree | 6a3201118da42e36a127254f883ba45aa889dde6 /configure.in | |
| parent | 9da70efcbe09954b1006f878d39885a4acf1c534 (diff) | |
Teach the configure script to validate its --with-pgport argument.
Previously, configure would take any string, including an empty string,
leading to obscure compile failures in guc.c. It seems worth expending
a few lines of code to ensure that the argument is a decimal number
between 1 and 65535.
Report and patch by Jim Nasby; reviews by Alex Shulgin, Peter Eisentraut,
Ivan Kartyshov
Diffstat (limited to 'configure.in')
| -rw-r--r-- | configure.in | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/configure.in b/configure.in index 0bd90d75019..0b7dd97506a 100644 --- a/configure.in +++ b/configure.in @@ -165,6 +165,17 @@ AC_DEFINE_UNQUOTED(DEF_PGPORT_STR, "${default_port}", [Define to the default TCP port number as a string constant.]) AC_SUBST(default_port) +# It's worth validating port; you can get very confusing errors otherwise +if test x"$default_port" = x""; then + AC_MSG_ERROR([invalid --with-pgport specification: empty string]) +elif test ! x`echo "$default_port" | sed -e 's/[[0-9]]*//'` = x""; then + AC_MSG_ERROR([invalid --with-pgport specification: must be a number]) +elif test ! x`echo "$default_port" | sed -e 's/^0.//'` = x"$default_port"; then + AC_MSG_ERROR([invalid --with-pgport specification: must not have leading 0]) +elif test "$default_port" -lt "1" -o "$default_port" -gt "65535"; then + AC_MSG_ERROR([invalid --with-pgport specification: must be between 1 and 65535]) +fi + # # '-rpath'-like feature can be disabled # |