diff options
| author | Thomas Munro | 2023-11-29 03:44:19 +0000 |
|---|---|---|
| committer | Thomas Munro | 2023-11-29 04:19:25 +0000 |
| commit | 15c9ac3629936a9bb5010155d3656e913027ccb7 (patch) | |
| tree | 7af568a8acbb602d6a1f758e640a8099456df7d2 /configure.ac | |
| parent | a60b8a58f435c44fc54e904cb05784b49dc04d0e (diff) | |
Optimize pg_readv/pg_pwritev single vector case.
For the trivial case of iovcnt == 1, kernels are measurably slower at
dealing with the more complex arguments of preadv/pwritev than the
equivalent plain old pread/pwrite. The overheads are worth it for
iovcnt > 1, but for 1 let's just redirect to the cheaper calls. While
we could leave it to callers to worry about that, we already have to
have our own pg_ wrappers for portability reasons so it seems
reasonable to centralize this knowledge there (thanks to Heikki for this
suggestion). Try to avoid function call overheads by making them
inlinable, which might also allow the compiler to avoid the branch in
some cases. For systems that don't have preadv and pwritev (currently:
Windows and [closed] Solaris), we might as well pull the replacement
functions up into the static inline functions too.
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/CA+hUKGJkOiOCa+mag4BF+zHo7qo=o9CFheB8=g6uT5TUm2gkvA@mail.gmail.com
Diffstat (limited to 'configure.ac')
| -rw-r--r-- | configure.ac | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac index fed7167e65d..e49de9e4f04 100644 --- a/configure.ac +++ b/configure.ac @@ -1816,10 +1816,10 @@ AC_CHECK_DECLS(posix_fadvise, [], [], [#include <fcntl.h>]) AC_CHECK_DECLS(fdatasync, [], [], [#include <unistd.h>]) AC_CHECK_DECLS([strlcat, strlcpy, strnlen]) -# We can't use AC_REPLACE_FUNCS to replace these functions, because it +# We can't use AC_CHECK_FUNCS to detect these functions, because it # won't handle deployment target restrictions on macOS -AC_CHECK_DECLS([preadv], [], [AC_LIBOBJ(preadv)], [#include <sys/uio.h>]) -AC_CHECK_DECLS([pwritev], [], [AC_LIBOBJ(pwritev)], [#include <sys/uio.h>]) +AC_CHECK_DECLS([preadv], [], [], [#include <sys/uio.h>]) +AC_CHECK_DECLS([pwritev], [], [], [#include <sys/uio.h>]) # This is probably only present on macOS, but may as well check always AC_CHECK_DECLS(F_FULLFSYNC, [], [], [#include <fcntl.h>]) |