diff options
| author | Heikki Linnakangas | 2014-02-10 07:55:14 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2014-02-10 08:00:04 +0000 |
| commit | f3807106b404c2e78961dd868adcb91d6d9ca6ee (patch) | |
| tree | 788fa9e51abc7a20b5df8b9967070b058f34ff05 | |
| parent | 165aa1da588abcbcf3494b38bc03cb0e46e8831b (diff) | |
Use memmove() instead of memcpy() for copying overlapping regions.
In commit d2495f272cd164ff075bee5c4ce95aed11338a36, I fixed this bug in
to_tsquery(), but missed the fact that plainto_tsquery() has the same bug.
| -rw-r--r-- | src/backend/tsearch/to_tsany.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/backend/tsearch/to_tsany.c b/src/backend/tsearch/to_tsany.c index bb886ee5849..10be08f6629 100644 --- a/src/backend/tsearch/to_tsany.c +++ b/src/backend/tsearch/to_tsany.c @@ -396,6 +396,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS) if (query->size == 0) PG_RETURN_TSQUERY(query); + /* clean out any stopword placeholders from the tree */ res = clean_fakeval(GETQUERY(query), &len); if (!res) { @@ -405,6 +406,10 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS) } memcpy((void *) GETQUERY(query), (void *) res, len * sizeof(QueryItem)); + /* + * Removing the stopword placeholders might've resulted in fewer + * QueryItems. If so, move the operands up accordingly. + */ if (len != query->size) { char *oldoperand = GETOPERAND(query); @@ -413,7 +418,7 @@ plainto_tsquery_byid(PG_FUNCTION_ARGS) Assert(len < query->size); query->size = len; - memcpy((void *) GETOPERAND(query), oldoperand, lenoperand); + memmove((void *) GETOPERAND(query), oldoperand, lenoperand); SET_VARSIZE(query, COMPUTESIZE(len, lenoperand)); } |