summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Riggs2018-06-14 11:17:51 +0000
committerSimon Riggs2018-06-14 11:17:51 +0000
commitdc878ffedf2aa461b11b617094101e3c4cf48daa (patch)
treef22c25f616f307f587afdbed97e907e1b4ac1c8a
parent802bde87ba3c64b28d019e8265c2d8948a027c9c (diff)
Remove spurious code comments in standby related code
GetRunningTransactionData() suggested that subxids were not worth optimizing away if overflowed, yet they have already been removed for that case. Changes to LogAccessExclusiveLock() API forgot to remove the prior comment when it was copied to LockAcquire().
-rw-r--r--src/backend/storage/ipc/procarray.c4
-rw-r--r--src/backend/storage/ipc/standby.c5
2 files changed, 1 insertions, 8 deletions
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index 31dddaf0ed5..518c6d74b29 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -1926,9 +1926,7 @@ ProcArrayInstallRestoredXmin(TransactionId xmin, PGPROC *proc)
* that bookkeeping.
*
* Note that if any transaction has overflowed its cached subtransactions
- * then there is no real need include any subtransactions. That isn't a
- * common enough case to worry about optimising the size of the WAL record,
- * and we may wish to see that data for diagnostic purposes anyway.
+ * then there is no real need include any subtransactions.
*/
RunningTransactions
GetRunningTransactionData(void)
diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
index 44ed20992ed..38d6db1e126 100644
--- a/src/backend/storage/ipc/standby.c
+++ b/src/backend/storage/ipc/standby.c
@@ -1050,11 +1050,6 @@ LogAccessExclusiveLock(Oid dbOid, Oid relOid)
xlrec.xid = GetCurrentTransactionId();
- /*
- * Decode the locktag back to the original values, to avoid sending lots
- * of empty bytes with every message. See lock.h to check how a locktag
- * is defined for LOCKTAG_RELATION
- */
xlrec.dbOid = dbOid;
xlrec.relOid = relOid;