diff options
| author | Peter Geoghegan | 2021-05-06 20:17:39 +0000 |
|---|---|---|
| committer | Peter Geoghegan | 2021-05-06 20:17:39 +0000 |
| commit | c9787385db47ba423d845b34d58e158551c6335d (patch) | |
| tree | 82a453448e00f576dc9efcfbb9d38b477ee0cf21 | |
| parent | 3fe773b149755977d2ffde2afd89557b39d0afd9 (diff) | |
Remove overzealous VACUUM visibility map assertion.
The all_visible_according_to_vm variable's value is inherently prone to
becoming invalidated concurrently, since it is set before we even
acquire a lock on a related heap page buffer.
Oversight in commit 7136bf34, which added the assertion in passing.
Author: Masahiko Sawada <sawada.mshk@gmail.com>
Reported-By: Tang <tanghy.fnst@fujitsu.com>
Diagnosed-By:: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAD21AoDzgc8_MYrA5m1fyydomw_eVKtQiYh7sfDK4KEhdMsf_g@mail.gmail.com
| -rw-r--r-- | src/backend/access/heap/vacuumlazy.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index c3fc12d76c7..47ac6385d12 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -1344,7 +1344,6 @@ lazy_scan_heap(LVRelState *vacrel, VacuumParams *params, bool aggressive) lazy_scan_prune(vacrel, buf, blkno, page, vistest, &prunestate); Assert(!prunestate.all_visible || !prunestate.has_lpdead_items); - Assert(!all_visible_according_to_vm || prunestate.all_visible); /* Remember the location of the last page with nonremovable tuples */ if (prunestate.hastup) |