summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMasahiko Sawada2025-03-18 04:34:10 +0000
committerMasahiko Sawada2025-03-18 04:34:10 +0000
commitc462b054ba605d23c1ec139fcca3d758ac139026 (patch)
treee487de4a75be2dc449bdb965f7cccb6ebb67d512
parent17caf6644546eccb4a1f6e0137ea1d0f58da8c16 (diff)
Fix the test 005_char_signedness.
pg_upgrade test 005_char_signedness was leaving files like delete_old_cluster.sh in the source directory for VPATH and meson builds. The fix is to change the directory to tmp_check before running the test. Reported-by: Robert Haas <robertmhaas@gmail.com> Reviewed-by: Robert Haas <robertmhaas@gmail.com> Discussion: http://postgr.es/m/CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com
-rw-r--r--src/bin/pg_upgrade/t/005_char_signedness.pl5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/bin/pg_upgrade/t/005_char_signedness.pl b/src/bin/pg_upgrade/t/005_char_signedness.pl
index 0190747758c..17fa0d48b15 100644
--- a/src/bin/pg_upgrade/t/005_char_signedness.pl
+++ b/src/bin/pg_upgrade/t/005_char_signedness.pl
@@ -45,6 +45,11 @@ command_like(
qr/Default char data signedness:\s+unsigned/,
'updated default char signedness is unsigned in control file');
+# In a VPATH build, we'll be started in the source directory, but we want
+# to run pg_upgrade in the build directory so that any files generated finish
+# in it, like delete_old_cluster.{sh,bat}.
+chdir ${PostgreSQL::Test::Utils::tmp_check};
+
# Cannot use --set-char-signedness option for upgrading from v18+
command_checks_all(
[