diff options
| author | Noah Misch | 2019-04-01 02:32:48 +0000 |
|---|---|---|
| committer | Noah Misch | 2019-04-01 02:32:52 +0000 |
| commit | ab7590e9197cd9b1ab691ab0b08794a79f26e592 (patch) | |
| tree | 043de2b84d340932b024cc52ab7775cf941d0380 | |
| parent | 4d6bd92db5105b8ecc2eedff430b080541a5e4de (diff) | |
Update HINT for pre-existing shared memory block.
One should almost always terminate an old process, not use a manual
removal tool like ipcrm. Removal of the ipcclean script eleven years
ago (39627b1ae680cba44f6e56ca5facec4fdbfe9495) and its non-replacement
corroborate that manual shm removal is now a niche goal. Back-patch to
9.4 (all supported versions).
Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI.
Discussion: https://postgr.es/m/20180812064815.GB2301738@rfd.leadboat.com
| -rw-r--r-- | src/backend/utils/init/miscinit.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index 98c2c1949d4..ce929d8806b 100644 --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -1066,14 +1066,10 @@ CreateLockFile(const char *filename, bool amPostmaster, if (PGSharedMemoryIsInUse(id1, id2)) ereport(FATAL, (errcode(ERRCODE_LOCK_FILE_EXISTS), - errmsg("pre-existing shared memory block " - "(key %lu, ID %lu) is still in use", + errmsg("pre-existing shared memory block (key %lu, ID %lu) is still in use", id1, id2), - errhint("If you're sure there are no old " - "server processes still running, remove " - "the shared memory block " - "or just delete the file \"%s\".", - filename))); + errhint("Terminate any old server processes associated with data directory \"%s\".", + refName))); } } |