summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Haas2022-04-22 20:16:52 +0000
committerRobert Haas2022-04-22 20:19:39 +0000
commita66e722cc1180cd7a2046fb552195a7d7703a592 (patch)
tree8827ce492b3f2469d6985ae98c4a57d03c582145
parent826be1ffb28dde083552150243dbbdcac55ab28e (diff)
Remove some recently-added pg_dump test cases.
Commit d2d35479796c3510e249d6fc72adbd5df918efbf included a pretty extensive set of test cases, and some of them don't work on all of our Windows machines. This happens because IPC::Run expands its arguments as shell globs on a few machines, but doesn't on most of the buildfarm. It might be good to fix that problem systematically somehow, but in the meantime, there are enough test cases for this commit that it seems OK to just remove the ones that are failing. Discussion: http://postgr.es/m/3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net Discussion: http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2H0HZLuPHqSy6VC8Ba7vdg@mail.gmail.com
-rw-r--r--src/bin/pg_dump/t/002_pg_dump.pl30
1 files changed, 0 insertions, 30 deletions
diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
index 1ecfd7ae235..3b31e13f62b 100644
--- a/src/bin/pg_dump/t/002_pg_dump.pl
+++ b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -3983,18 +3983,6 @@ $node->command_fails_like(
);
$node->command_fails_like(
- [ 'pg_dumpall', '--exclude-database', '.*' ],
- qr/pg_dumpall: error: improper qualified name \(too many dotted names\): \.\*/,
- 'pg_dumpall: option --exclude-database rejects multipart pattern ".*"'
-);
-
-$node->command_fails_like(
- [ 'pg_dumpall', '--exclude-database', '*.*' ],
- qr/pg_dumpall: error: improper qualified name \(too many dotted names\): \*\.\*/,
- 'pg_dumpall: option --exclude-database rejects multipart pattern "*.*"'
-);
-
-$node->command_fails_like(
[ 'pg_dumpall', '--exclude-database', 'myhost.mydb' ],
qr/pg_dumpall: error: improper qualified name \(too many dotted names\): myhost\.mydb/,
'pg_dumpall: option --exclude-database rejects multipart database names'
@@ -4008,12 +3996,6 @@ $node->command_ok(
'pg_dumpall: option --exclude-database handles database names with embedded dots'
);
-$node->command_ok(
- [ 'pg_dumpall', '--exclude-database', '??*' ],
- 'pg_dumpall: option --exclude-database handles database name patterns'
-);
-
-
#########################################
# Test invalid multipart schema names
@@ -4042,23 +4024,11 @@ $node->command_fails_like(
);
$node->command_fails_like(
- [ 'pg_dump', '--schema', '.*' ],
- qr/pg_dump: error: cross-database references are not implemented: \.\*/,
- 'pg_dump: option --schema rejects degenerate two-part schema name: ".*"'
-);
-
-$node->command_fails_like(
[ 'pg_dump', '--schema', '..' ],
qr/pg_dump: error: improper qualified name \(too many dotted names\): \.\./,
'pg_dump: option --schema rejects degenerate three-part schema name: ".."'
);
-$node->command_fails_like(
- [ 'pg_dump', '--schema', '.*.*' ],
- qr/pg_dump: error: improper qualified name \(too many dotted names\): \.\*\.\*/,
- 'pg_dump: option --schema rejects degenerate three-part schema pattern: ".*.*"'
-);
-
#########################################
# Test invalid multipart relation names