diff options
| author | Tom Lane | 2017-05-07 16:33:12 +0000 |
|---|---|---|
| committer | Tom Lane | 2017-05-07 16:33:31 +0000 |
| commit | 9e5f3d013690c7b1b147ac20d3d61dad683a4141 (patch) | |
| tree | 50360a77c0375f30b303ab6269af9f34ee7f2bf3 | |
| parent | 5971accd8b08516916c92081ec5576b306712981 (diff) | |
Guard against null t->tm_zone in strftime.c.
The upstream IANA code does not guard against null TM_ZONE pointers in this
function, but in our code there is such a check in the other pre-existing
use of t->tm_zone. We do have some places that set pg_tm.tm_zone to NULL.
I'm not entirely sure it's possible to reach strftime with such a value,
but I'm not sure it isn't either, so be safe.
Per Coverity complaint.
| -rw-r--r-- | src/timezone/strftime.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/timezone/strftime.c b/src/timezone/strftime.c index ab8f60e9c8f..2f32cf8bdb7 100644 --- a/src/timezone/strftime.c +++ b/src/timezone/strftime.c @@ -459,7 +459,8 @@ _fmt(const char *format, const struct pg_tm * t, char *pt, const char *ptlim, negative = diff < 0; if (diff == 0) { - negative = t->tm_zone[0] == '-'; + if (t->tm_zone != NULL) + negative = t->tm_zone[0] == '-'; } if (negative) { |