summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane2016-01-17 16:38:40 +0000
committerTom Lane2016-01-17 16:38:40 +0000
commit57ce9acc04483df4913921d4ff21f01483583fb8 (patch)
tree99ec3fb2fc8aae11556ab294b89d0b9028edda41
parent4189e3d659abb48d159a6c3faabaa7e99498ca3e (diff)
Remove dead code in pg_dump.
Coverity quite reasonably complained that this check for fout==NULL occurred after we'd already dereferenced fout. However, the check is just dead code since there is no code path by which CreateArchive can return a null pointer. Errors such as can't-open-that-file are reported down inside CreateArchive, and control doesn't return. So let's silence the warning by removing the dead code, rather than continuing to pretend it does something. Coverity didn't complain about this before 5b5fea2a1, so back-patch to 9.5 like that patch.
-rw-r--r--src/bin/pg_dump/pg_dump.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 9196cf44d98..59542aa1d3d 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -617,9 +617,6 @@ main(int argc, char **argv)
/* Register the cleanup hook */
on_exit_close_archive(fout);
- if (fout == NULL)
- exit_horribly(NULL, "could not open output file \"%s\" for writing\n", filename);
-
/* Let the archiver know how noisy to be */
fout->verbose = g_verbose;