diff options
| author | Heikki Linnakangas | 2009-10-08 04:46:52 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2009-10-08 04:46:52 +0000 |
| commit | 469301e6eeca722af251f153a6db18471f72f946 (patch) | |
| tree | 548d784d0ffd928fa76b0900d1bf40505d78fbe7 | |
| parent | 595f2744b0498e5b82649242aae35553761f3081 (diff) | |
Fix off-by-one bug in bitncmp(): When comparing a number of bits divisible by
8, bitncmp() may dereference a pointer one byte out of bounds.
Chris Mikkelson (bug #5101)
| -rw-r--r-- | src/backend/utils/adt/network.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/adt/network.c b/src/backend/utils/adt/network.c index 3b526d0655b..342838f63f3 100644 --- a/src/backend/utils/adt/network.c +++ b/src/backend/utils/adt/network.c @@ -1,7 +1,7 @@ /* * PostgreSQL type definitions for the INET and CIDR types. * - * $PostgreSQL: pgsql/src/backend/utils/adt/network.c,v 1.56 2005/10/17 16:24:19 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/utils/adt/network.c,v 1.56.2.1 2009/10/08 04:46:52 heikki Exp $ * * Jon Postel RIP 16 Oct 1998 */ @@ -897,7 +897,7 @@ bitncmp(void *l, void *r, int n) b = n / 8; x = memcmp(l, r, b); - if (x) + if (x || (n % 8) == 0) return (x); lb = ((const u_char *) l)[b]; |