summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephen Frost2013-07-15 01:17:59 +0000
committerStephen Frost2013-07-15 01:17:59 +0000
commit3355443fb188b86d59ca90912d5456b427c29116 (patch)
tree100dd1ddec253a6e3b6d121bde3c6793c20fcc54
parent01337d46eb34503b81b989885d0aa3e25da5a96d (diff)
Check version before allocating PQExpBuffer
In pg_dump.c:getEventTriggers, check what major version we are on before calling createPQExpBuffer() to avoid leaking that bit of memory. Leak discovered by the Coverity scanner. Back-patch to 9.3 where support for dumping event triggers was added.
-rw-r--r--src/bin/pg_dump/pg_dump.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index f40961ffcea..dfa3ff7da54 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -5746,7 +5746,7 @@ EventTriggerInfo *
getEventTriggers(Archive *fout, int *numEventTriggers)
{
int i;
- PQExpBuffer query = createPQExpBuffer();
+ PQExpBuffer query;
PGresult *res;
EventTriggerInfo *evtinfo;
int i_tableoid,
@@ -5766,6 +5766,8 @@ getEventTriggers(Archive *fout, int *numEventTriggers)
return NULL;
}
+ query = createPQExpBuffer();
+
/* Make sure we are in proper schema */
selectSourceSchema(fout, "pg_catalog");