diff options
| author | Tom Lane | 2012-09-06 01:49:11 +0000 |
|---|---|---|
| committer | Tom Lane | 2012-09-06 01:49:11 +0000 |
| commit | 308d4ec4c677a2ced29b82dde811b1cbba8c3201 (patch) | |
| tree | ff3d8440ef35be8000b0fb9af2886cddd15dc341 | |
| parent | 8a66a37d6df5a27cc2b5ec3b59322c974e0b1ef6 (diff) | |
Fix inappropriate error messages for Hot Standby misconfiguration errors.
Give the correct name of the GUC parameter being complained of.
Also, emit a more suitable SQLSTATE (INVALID_PARAMETER_VALUE,
not the default INTERNAL_ERROR).
Gurjeet Singh, errcode adjustment by me
| -rw-r--r-- | src/backend/access/transam/xlog.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 52bc469f296..83d8f53a9a7 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -5990,9 +5990,10 @@ GetXLogReceiptTime(TimestampTz *rtime, bool *fromStream) */ #define RecoveryRequiresIntParameter(param_name, currValue, minValue) \ do { \ - if (currValue < minValue) \ + if ((currValue) < (minValue)) \ ereport(ERROR, \ - (errmsg("hot standby is not possible because " \ + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), \ + errmsg("hot standby is not possible because " \ "%s = %d is a lower setting than on the master server " \ "(its value was %d)", \ param_name, \ @@ -6033,10 +6034,10 @@ CheckRequiredParameterValues(void) RecoveryRequiresIntParameter("max_connections", MaxConnections, ControlFile->MaxConnections); - RecoveryRequiresIntParameter("max_prepared_xacts", + RecoveryRequiresIntParameter("max_prepared_transactions", max_prepared_xacts, ControlFile->max_prepared_xacts); - RecoveryRequiresIntParameter("max_locks_per_xact", + RecoveryRequiresIntParameter("max_locks_per_transaction", max_locks_per_xact, ControlFile->max_locks_per_xact); } |