diff options
| author | Tom Lane | 2022-10-17 16:14:39 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-10-17 16:14:39 +0000 |
| commit | 2f26cec4884366cc23737c5a9b7797935057ce38 (patch) | |
| tree | 01e44d43e7baf894b549fd57b009cec12dbdede4 | |
| parent | 8c611602bd356cbb47c3ebe8614f958391ec92a8 (diff) | |
Reject non-ON-SELECT rules that are named "_RETURN".
DefineQueryRewrite() has long required that ON SELECT rules be named
"_RETURN". But we overlooked the converse case: we should forbid
non-ON-SELECT rules that are named "_RETURN". In particular this
prevents using CREATE OR REPLACE RULE to overwrite a view's _RETURN
rule with some other kind of rule, thereby breaking the view.
Per bug #17646 from Kui Liu. Back-patch to all supported branches.
Discussion: https://postgr.es/m/17646-70c93cfa40365776@postgresql.org
| -rw-r--r-- | src/backend/rewrite/rewriteDefine.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c index 27e4ef911c8..5af42c203ce 100644 --- a/src/backend/rewrite/rewriteDefine.c +++ b/src/backend/rewrite/rewriteDefine.c @@ -531,6 +531,18 @@ DefineQueryRewrite(const char *rulename, RelationGetDescr(event_relation), false, false); } + + /* + * And finally, if it's not an ON SELECT rule then it must *not* be + * named _RETURN. This prevents accidentally or maliciously replacing + * a view's ON SELECT rule with some other kind of rule. + */ + if (strcmp(rulename, ViewSelectRuleName) == 0) + ereport(ERROR, + (errcode(ERRCODE_INVALID_OBJECT_DEFINITION), + errmsg("non-view rule for \"%s\" must not be named \"%s\"", + RelationGetRelationName(event_relation), + ViewSelectRuleName))); } /* |