diff options
| author | Noah Misch | 2018-04-26 01:50:29 +0000 |
|---|---|---|
| committer | Noah Misch | 2018-04-26 01:50:33 +0000 |
| commit | 24f1e9ca0b9261dd6ae3c16cebbcc572732f3587 (patch) | |
| tree | 2ebd782efdf53998726a850210ac003fe05c57fd | |
| parent | 168df1b844d3ff0f8ae392f9d3a6cdcaf9f76311 (diff) | |
Correct pg_recvlogical server version test.
The predecessor test boiled down to "PQserverVersion(NULL) >= 100000",
which is always false. No release includes that, so it could not have
reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the
predecessor in commit 8d2814f274def85f39fbe997d454b01628cb5667.
Discussion: https://postgr.es/m/20180422215551.GB2676194@rfd.leadboat.com
| -rw-r--r-- | src/bin/pg_basebackup/streamutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c index 92065439457..bdeab3aea56 100644 --- a/src/bin/pg_basebackup/streamutil.c +++ b/src/bin/pg_basebackup/streamutil.c @@ -215,7 +215,7 @@ GetConnection(void) * 10, so the search path cannot be changed (by us or attackers) on * earlier versions. */ - if (dbname != NULL && PQserverVersion(conn) >= 100000) + if (dbname != NULL && PQserverVersion(tmpconn) >= 100000) { PGresult *res; |